Reland 'Convert //net and //chromecast to std::unordered_*'

Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864, 554287
Committed: https://crrev.com/1e912eaa1a32f9882be02f12244ec952b67f9505
Cr-Commit-Position: refs/heads/master@{#388545}

[davidben, 2016-04-18 20:07:13]

Description was changed from

==========
Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

BUG=576864,554287
==========

to

==========
Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864,554287
==========

[davidben, 2016-04-18 20:08:46]

davidben@chromium.org changed reviewers:
+ lcwu@chromium.org, mmenke@chromium.org, sky@chromium.org

[davidben, 2016-04-18 20:08:47]

sky for content/public/test/test_download_request_handler.cc

TBR mmenke and lcwu since, modulo a rebase and the file sky is reviewing, this
is the same CL as before. But I'll wait for try jobs to complete to make sure
nothing went wrong.

[mmenke, 2016-04-18 20:31:48]

On 2016/04/18 20:08:47, davidben wrote:
> sky for content/public/test/test_download_request_handler.cc
> 
> TBR mmenke and lcwu since, modulo a rebase and the file sky is reviewing, this
> is the same CL as before. But I'll wait for try jobs to complete to make sure
> nothing went wrong.

The issue was just different erase behavior when the erase call deletes the key
that was used to erase the element?  LGTM.

[davidben, 2016-04-18 20:35:57]

On 2016/04/18 20:31:48, mmenke wrote:
> On 2016/04/18 20:08:47, davidben wrote:
> > sky for content/public/test/test_download_request_handler.cc
> > 
> > TBR mmenke and lcwu since, modulo a rebase and the file sky is reviewing,
this
> > is the same CL as before. But I'll wait for try jobs to complete to make
sure
> > nothing went wrong.
> 
> The issue was just different erase behavior when the erase call deletes the
key
> that was used to erase the element?  LGTM.

Yeah. The difference is ScopedPtrHashMap::erase(key) cashes the key in for an
iterator and then erases the iterator, so it's fine if the key gets destroyed as
part of the erase. But I guess the native std::unordered_map::erase(key) works
differently.

[halliwell, 2016-04-19 01:26:54]

On 2016/04/18 20:35:57, davidben wrote:
> On 2016/04/18 20:31:48, mmenke wrote:
> > On 2016/04/18 20:08:47, davidben wrote:
> > > sky for content/public/test/test_download_request_handler.cc
> > > 
> > > TBR mmenke and lcwu since, modulo a rebase and the file sky is reviewing,
> this
> > > is the same CL as before. But I'll wait for try jobs to complete to make
> sure
> > > nothing went wrong.
> > 
> > The issue was just different erase behavior when the erase call deletes the
> key
> > that was used to erase the element?  LGTM.
> 
> Yeah. The difference is ScopedPtrHashMap::erase(key) cashes the key in for an
> iterator and then erases the iterator, so it's fine if the key gets destroyed
as
> part of the erase. But I guess the native std::unordered_map::erase(key) works
> differently.

chromecast/ lgtm

[davidben, 2016-04-20 02:35:21]

davidben@chromium.org changed reviewers:
+ creis@chromium.org

[davidben, 2016-04-20 02:35:22]

+creis for content

[Charlie Reis, 2016-04-20 16:51:43]

Ok, content/ LGTM.

[davidben, 2016-04-20 17:05:36]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-04-20 17:05:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897033002/20001

[commit-bot: I haz the power, 2016-04-20 19:17:20]

Description was changed from

==========
Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864,554287
==========

to

==========
Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864,554287
==========

[commit-bot: I haz the power, 2016-04-20 19:17:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:25:16]

Description was changed from

==========
Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864,554287
==========

to

==========
Reland 'Convert //net and //chromecast to std::unordered_*'

Relanded with a fix to TestDownloadRequestHandler.

> Do //chromecast at the same time as //net since there aren't many
> uses in //chromecast and one needs to be changed to mirror a //net
> API change.
>
> Review URL: https://codereview.chromium.org/1869503003
>
> Cr-Commit-Position: refs/heads/master@{#386485}

TBR=lcwu@chromium.org,mmenke@chromium.org
BUG=576864,554287

Committed: https://crrev.com/1e912eaa1a32f9882be02f12244ec952b67f9505
Cr-Commit-Position: refs/heads/master@{#388545}
==========

[commit-bot: I haz the power, 2016-04-22 19:25:17]

Patchset 2 (id:??) landed as
https://crrev.com/1e912eaa1a32f9882be02f12244ec952b67f9505
Cr-Commit-Position: refs/heads/master@{#388545}