Convert //net and //chromecast to std::unordered_*

Convert //net and //chromecast to std::unordered_*

Do //chromecast at the same time as //net since there aren't many
uses in //chromecast and one needs to be changed to mirror a //net
API change.

BUG=576864, 554287
Committed: https://crrev.com/4241ad1dee5396c329a5e9379c3db3027f1b6456
Cr-Commit-Position: refs/heads/master@{#386485}

[davidben, 2016-04-06 19:18:39]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2016-04-06 21:02:22]

LGTM

https://codereview.chromium.org/1869503003/diff/1/net/base/network_change_not...
File net/base/network_change_notifier_linux.cc (right):

https://codereview.chromium.org/1869503003/diff/1/net/base/network_change_not...
net/base/network_change_notifier_linux.cc:7: #include <unordered_set>
nit:  Already included in the header

[davidben, 2016-04-07 21:29:10]

Description was changed from

==========
Convert //net to std::unordered_*

BUG=576864,554287
==========

to

==========
Convert //net and //chromecast to std::unordered_*

Do //chromecast at the same time as //net since there aren't many
uses in //chromecast and one needs to be changed to mirror a //net
API change.

BUG=576864,554287
==========

[davidben, 2016-04-07 21:30:40]

davidben@chromium.org changed reviewers:
+ lcwu@chromium.org

[davidben, 2016-04-07 21:30:41]

+lcwu for //chromecast.

https://codereview.chromium.org/1869503003/diff/1/net/base/network_change_not...
File net/base/network_change_notifier_linux.cc (right):

https://codereview.chromium.org/1869503003/diff/1/net/base/network_change_not...
net/base/network_change_notifier_linux.cc:7: #include <unordered_set>
On 2016/04/06 21:02:22, mmenke wrote:
> nit:  Already included in the header

Done.

[lcwu1, 2016-04-08 04:57:06]

chromecast/ lgtm

[davidben, 2016-04-08 05:36:56]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-04-08 05:36:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1869503003/#ps40001
(title: "fix cast build")

[commit-bot: I haz the power, 2016-04-08 05:37:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869503003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869503003/40001

[commit-bot: I haz the power, 2016-04-08 05:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 05:41:14]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[davidben, 2016-04-11 17:16:33]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-04-11 17:16:34]

The patchset sent to the CQ was uploaded after l-g-t-m from lcwu@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1869503003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-11 17:16:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869503003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869503003/60001

[commit-bot: I haz the power, 2016-04-11 17:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 17:36:37]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[davidben, 2016-04-11 19:27:58]

lcwu: PTAL. I had to tweak the chromecast bit very slightly.

https://codereview.chromium.org/1869503003/diff/80001/chromecast/base/device_...
File chromecast/base/device_capabilities_impl.cc (right):

https://codereview.chromium.org/1869503003/diff/80001/chromecast/base/device_...
chromecast/base/device_capabilities_impl.cc:154: validator_map_[key] =
base::WrapUnique(new ValidatorInfo(validator));
This technically changes behavior in the failed DCHECK case. If we want to
completely emulate the old behavior, it'd be:

  bool added = validator_map_.insert(std::make_pair(key, base::WrapUnique(new
ValidatorInfo(validator)))).second;
  DCHECK(added);

But that's a mouthful and there's a DCHECK, so I assumed this version is
preferable.

[lcwu1, 2016-04-11 21:43:04]

https://codereview.chromium.org/1869503003/diff/80001/chromecast/base/device_...
File chromecast/base/device_capabilities_impl.cc (right):

https://codereview.chromium.org/1869503003/diff/80001/chromecast/base/device_...
chromecast/base/device_capabilities_impl.cc:154: validator_map_[key] =
base::WrapUnique(new ValidatorInfo(validator));
On 2016/04/11 19:27:58, davidben (OOO 4-4 to 4-11) wrote:
> This technically changes behavior in the failed DCHECK case. If we want to
> completely emulate the old behavior, it'd be:
> 
>   bool added = validator_map_.insert(std::make_pair(key, base::WrapUnique(new
> ValidatorInfo(validator)))).second;
>   DCHECK(added);
> 
> But that's a mouthful and there's a DCHECK, so I assumed this version is
> preferable.

Yes, I like the new implementation better. Thanks for doing this.

lgtm

[davidben, 2016-04-11 21:44:06]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-04-11 21:44:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1869503003/#ps80001
(title: "fix cast")

[commit-bot: I haz the power, 2016-04-11 21:44:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869503003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869503003/80001

[commit-bot: I haz the power, 2016-04-11 22:00:07]

Description was changed from

==========
Convert //net and //chromecast to std::unordered_*

Do //chromecast at the same time as //net since there aren't many
uses in //chromecast and one needs to be changed to mirror a //net
API change.

BUG=576864,554287
==========

to

==========
Convert //net and //chromecast to std::unordered_*

Do //chromecast at the same time as //net since there aren't many
uses in //chromecast and one needs to be changed to mirror a //net
API change.

BUG=576864,554287
==========

[commit-bot: I haz the power, 2016-04-11 22:00:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-11 22:02:06]

Description was changed from

==========
Convert //net and //chromecast to std::unordered_*

Do //chromecast at the same time as //net since there aren't many
uses in //chromecast and one needs to be changed to mirror a //net
API change.

BUG=576864,554287
==========

to

==========
Convert //net and //chromecast to std::unordered_*

Do //chromecast at the same time as //net since there aren't many
uses in //chromecast and one needs to be changed to mirror a //net
API change.

BUG=576864,554287

Committed: https://crrev.com/4241ad1dee5396c329a5e9379c3db3027f1b6456
Cr-Commit-Position: refs/heads/master@{#386485}
==========

[commit-bot: I haz the power, 2016-04-11 22:02:07]

Patchset 5 (id:??) landed as
https://crrev.com/4241ad1dee5396c329a5e9379c3db3027f1b6456
Cr-Commit-Position: refs/heads/master@{#386485}

[kjellander_chromium, 2016-04-12 08:14:16]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1884453002/ by kjellander@chromium.org.

The reason for reverting is: Speculatively reverting this since it was in the
blamelist
https://chromium.googlesource.com/chromium/src/+log/39399be2c6a0063520d8d9b28...
that I came up with after analyzing the content_browsertests failures
(DownloadContentTest) on 
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...
and
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2....

[davidben, 2016-04-18 19:52:41]

On 2016/04/12 08:14:16, kjellander (chromium) wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/1884453002/ by mailto:kjellander@chromium.org.
> 
> The reason for reverting is: Speculatively reverting this since it was in the
> blamelist
>
https://chromium.googlesource.com/chromium/src/+log/39399be2c6a0063520d8d9b28...
> that I came up with after analyzing the content_browsertests failures
> (DownloadContentTest) on 
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...
> and
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2....

Bleh. I see the problem.

void TestDownloadRequestHandler::Interceptor::Unregister() {
  net::URLRequestFilter* filter = net::URLRequestFilter::GetInstance();
  filter->RemoveUrlHandler(url_);
  // We are deleted now since the filter owned |this|.
}

RemoveUrlHandler deletes |this|, so we can't pass in |url_|.