Issue 18970003: Introduce isHTMLOptGroupElement and toHTMLOptGroupElement

Issue 18970003: Introduce isHTMLOptGroupElement and toHTMLOptGroupElement (Closed)

Created:
7 years, 5 months ago by kangil_

Modified:
7 years, 5 months ago

Reviewers:
tkent, jochen (gone - plz use gerrit)

CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce isHTMLOptGroupElement and toHTMLOptGroupElement To avoid direct use of static_cast, this patch introduces isHTMLOptGroupElement and toHTMLOptGroupElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153884

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -32 lines)			Patch
M	Source/core/accessibility/AccessibilityListBoxOption.cpp	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLOptGroupElement.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLOptionElement.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/parser/HTMLConstructionSite.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/parser/HTMLElementStack.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/parser/HTMLTreeBuilder.cpp	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderListBox.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/rendering/RenderMenuList.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18970003/1

7 years, 5 months ago (2013-07-10 07:26:50 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=15766

7 years, 5 months ago (2013-07-10 08:09:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18970003/1

7 years, 5 months ago (2013-07-10 08:23:19 UTC) #5

Message was sent while issue was closed.

Change committed as 153884

Expand Messages | Collapse Messages