Source/core/html/parser/HTMLConstructionSite.cpp - Issue 18970003: Introduce isHTMLOptGroupElement and toHTMLOptGroupElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLConstructionSite.cpp

Issue 18970003: Introduce isHTMLOptGroupElement and toHTMLOptGroupElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/parser/HTMLConstructionSite.cpp

diff --git a/Source/core/html/parser/HTMLConstructionSite.cpp b/Source/core/html/parser/HTMLConstructionSite.cpp

index 9e74f169c585411620543a60577a30ee052851a8..10643a2935c2c7ab26ad2dced342512e773333c2 100644

--- a/Source/core/html/parser/HTMLConstructionSite.cpp

+++ b/Source/core/html/parser/HTMLConstructionSite.cpp

@@ -37,6 +37,7 @@

#include "core/dom/Text.h"

#include "core/html/HTMLFormElement.h"

#include "core/html/HTMLHtmlElement.h"

+#include "core/html/HTMLOptGroupElement.h"

#include "core/html/HTMLScriptElement.h"

#include "core/html/HTMLTemplateElement.h"

#include "core/html/parser/AtomicHTMLToken.h"

@@ -68,7 +69,7 @@ static bool hasImpliedEndTag(const HTMLStackItem* item)

|| item->hasTagName(dtTag)

|| item->hasTagName(liTag)

|| item->hasTagName(optionTag)

- || item->hasTagName(optgroupTag)

+ || isHTMLOptGroupElement(item->node())

|| item->hasTagName(pTag)

|| item->hasTagName(rpTag)

|| item->hasTagName(rtTag);

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/parser/HTMLElementStack.cpp » ('j') | no next file with comments »