Hook up style invalidation for CSS Paint API.

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "core/style/ComputedStyle.h"
 
+#include "core/css/CSSPaintValue.h"
+#include "core/css/CSSPropertyEquality.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/layout/TextAutosizer.h"
 #include "core/style/AppliedTextDecoration.h"
 #include "core/style/BorderEdge.h"
 #include "core/style/ContentData.h"
 #include "core/style/DataEquivalency.h"
 #include "core/style/ComputedStyleConstants.h"
 #include "core/style/QuotesData.h"
 #include "core/style/ShadowList.h"
@@ skipping 717 matching lines @@
             || (visitedLinkBorderBottomColor() != other.visitedLinkBorderBottomColor() && borderBottomWidth())
             || (visitedLinkBorderTopColor() != other.visitedLinkBorderTopColor() && borderTopWidth())
             || (visitedLinkOutlineColor() != other.visitedLinkOutlineColor() && outlineWidth())
             || (visitedLinkBackgroundColor() != other.visitedLinkBackgroundColor()))
             return true;
     }
 
     if (resize() != other.resize())
         return true;
 
+    const StyleImage* image = borderImage().image();

[ikilpatrick, 2016/04/19 22:31:25]

Should this block be if-guarded with:
1) if (RuntimeEnabledFeatures::CSSPaintAPI)?
2) if (hasSomePaintImageOnStyle())?

for hasSomePaintImageOnStyle(), this bool would be set in StyleResolverState?,
and all image calls would have to proxy through that?

[rune, 2016/04/27 11:34:34]

Something like that. I would check the performance impact first to see how big a
problem this is. Anyway, I think that I would have put the added code into a
separate method.

[ikilpatrick, 2016/04/28 22:30:16]

Changed this quite a bit now after chat with elliott. Ran it quickly against
some perftests to sanity check.

+    if (image && image->isPaintImage() && diffNeedsPaintInvalidationObjectForPaintImage(image, other))

[rune, 2016/04/27 11:34:34]

So the assumption here is that the image pointers are equal (possibly both
nullptr), and the sizes did not change, or otherwise this method would have
returned true for visuallyEqual above? The code here is to check if a repaint
would produce a different result due to property changes?

[ikilpatrick, 2016/04/28 22:30:16]

Yup thats correct. 

+        return true;
+
+    const StyleImage* listImage = listStyleImage();
+    if (listImage && listImage->isPaintImage() && diffNeedsPaintInvalidationObjectForPaintImage(listImage, other))
+        return true;
+
+    for (const FillLayer* bgLayer = &m_background->background(); bgLayer; bgLayer = bgLayer->next()) {
+        if (bgLayer->image() && bgLayer->image()->isPaintImage() && diffNeedsPaintInvalidationObjectForPaintImage(bgLayer->image(), other))
+            return true;
+    }
+
+    for (const ContentData* data = contentData(); data; data = data->next()) {
+        if (data->isImage() && toImageContentData(data)->image()->isPaintImage() && diffNeedsPaintInvalidationObjectForPaintImage(toImageContentData(data)->image(), other))
+            return true;
+    }
+
     return false;
 }
 
+bool ComputedStyle::diffNeedsPaintInvalidationObjectForPaintImage(const StyleImage* image, const ComputedStyle& other) const
+{
+    CSSPaintValue* value = toCSSPaintValue(image->cssValue());
+
+    for (CSSPropertyID propertyID : value->nativeInvalidationProperties()) {
+        if (!CSSPropertyEquality::propertiesEqual(propertyID, *this, other))
+            return true;
+    }
+
+    for (const AtomicString& property : value->customInvalidationProperties()) {
+        CSSVariableData* thisVar = variables() ? variables()->getVariable(property) : nullptr;
+        CSSVariableData* otherVar = other.variables() ? other.variables()->getVariable(property) : nullptr;

[rune, 2016/04/27 11:34:34]

The variable is resolved at this point, I guess? (in case you have --x:
var(--y))

[ikilpatrick, 2016/04/28 22:30:16]

Yup, the variables are resolved with each other at this point, added test case
for this.

+        if (thisVar != otherVar)

[rune, 2016/04/27 11:34:34]

A pointer comparison. Is that correct?

If one of them is nullptr, there is no concept of a initial value for css paint
which could be optimized further? For instance if there is a default shape for a
painter like "circle" so that "--paint-shape: circle" gives the same result as
not specifying --paint-shape at all?

[ikilpatrick, 2016/04/28 22:30:16]

Oh, yeah completely not correct. Sorry about that.

This now serializes the CSSVariableData and does a string compare on that.

Internally CSSVariableData stores a list of CSSParserTokens, but doing a compare
on the tokens is not correct as they do a pointer compare internally, see:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

+            return true;
+    }
+
+    return false;
+}
+
 void ComputedStyle::updatePropertySpecificDifferences(const ComputedStyle& other, StyleDifference& diff) const
 {
     // StyleAdjuster has ensured that zIndex is non-auto only if it's applicable.
     if (m_box->zIndex() != other.m_box->zIndex() || m_box->hasAutoZIndex() != other.m_box->hasAutoZIndex())
         diff.setZIndexChanged();
 
     if (rareNonInheritedData.get() != other.rareNonInheritedData.get()) {
         if (!transformDataEquivalent(other))
             diff.setTransformChanged();
 
@@ skipping 1028 matching lines @@
     if (!shadowList)
         return false;
     for (size_t i = shadowList->shadows().size(); i--; ) {
         if (shadowList->shadows()[i].color().isCurrentColor())
             return true;
     }
     return false;
 }
 
 } // namespace blink