Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1896853004: Code completion test cleanup, rename test_DefaultFormalParameter_named_expression_filter as test_Ar… (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Code completion test cleanup, rename test_DefaultFormalParameter_named_expression_filter as test_ArgumentList_namedParam_filter in local_reference_contributor_test.dart R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/345051cf1c8a0852c0c62b3d9682603037535ff1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 2 chunks +39 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
4 years, 8 months ago (2016-04-18 20:35:36 UTC) #2
danrubel
LGTM
4 years, 8 months ago (2016-04-19 18:38:11 UTC) #3
jwren
4 years, 8 months ago (2016-04-20 18:08:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
345051cf1c8a0852c0c62b3d9682603037535ff1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698