Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart

Issue 1896853004: Code completion test cleanup, rename test_DefaultFormalParameter_named_expression_filter as test_Ar… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
index 71bb3b2e09a9a580b7c92b7c378dccc65de92836..e2321fba9c71bc41b6e88c9cdb4131ca2ffe1501 100644
--- a/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
@@ -331,6 +331,45 @@ void main() {expect(foo: ^)}''');
assertNotSuggested('main');
}
+ test_ArgumentList_namedParam_filter() async {
+ // SimpleIdentifier NamedExpression ArgumentList
+ // InstanceCreationExpression
+ addTestSource('''
+ class A {}
+ class B extends A {}
+ class C implements A {}
+ class D {}
+ class E {
+ A a;
+ E({A someA});
+ }
+ A a = new A();
+ B b = new B();
+ C c = new C();
+ D d = new D();
+ E e = new E(someA: ^);
+ ''');
+ await computeSuggestions();
+
+ expect(replacementOffset, completionOffset);
+ expect(replacementLength, 0);
+ assertSuggestTopLevelVar('a', 'A',
+ relevance:
+ DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE + DART_RELEVANCE_INCREMENT);
+ assertSuggestTopLevelVar('b', 'B',
+ relevance:
+ DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE + DART_RELEVANCE_INCREMENT);
+ assertSuggestTopLevelVar('c', 'C',
+ relevance:
+ DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE + DART_RELEVANCE_INCREMENT);
+ assertSuggestTopLevelVar('d', 'D',
+ relevance: DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE);
+ assertSuggestTopLevelVar('e', 'E',
+ relevance: DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE);
+ }
+
+
+
test_AsExpression_type() async {
// SimpleIdentifier TypeName AsExpression
addTestSource('''
@@ -1886,42 +1925,6 @@ class A {a(blat: ^) { }}''');
assertNotSuggested('bar');
}
- test_DefaultFormalParameter_named_expression_filter() async {
- // DefaultFormalParameter FormalParameterList MethodDeclaration
- addTestSource('''
- class A {}
- class B extends A {}
- class C implements A {}
- class D {}
- class E {
- A a;
- E({A someA});
- }
- A a = new A();
- B b = new B();
- C c = new C();
- D d = new D();
- E e = new E(someA: ^);
- ''');
- await computeSuggestions();
-
- expect(replacementOffset, completionOffset);
- expect(replacementLength, 0);
- assertSuggestTopLevelVar('a', 'A',
- relevance:
- DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE + DART_RELEVANCE_INCREMENT);
- assertSuggestTopLevelVar('b', 'B',
- relevance:
- DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE + DART_RELEVANCE_INCREMENT);
- assertSuggestTopLevelVar('c', 'C',
- relevance:
- DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE + DART_RELEVANCE_INCREMENT);
- assertSuggestTopLevelVar('d', 'D',
- relevance: DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE);
- assertSuggestTopLevelVar('e', 'E',
- relevance: DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE);
- }
-
test_enum() async {
addTestSource('enum E { one, two } main() {^}');
await computeSuggestions();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698