Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1896843002: Store and serialize NativeBehavior in TreeElements. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -49 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 3 chunks +79 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 5 chunks +31 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 6 chunks +10 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 19 chunks +54 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 3 chunks +49 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 5 chunks +26 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/universe/side_effects.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_helper.dart View 5 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-18 14:34:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/native/behavior.dart File pkg/compiler/lib/src/native/behavior.dart (right): https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/native/behavior.dart#newcode36 pkg/compiler/lib/src/native/behavior.dart:36: default: do you expect to add more cases ...
4 years, 8 months ago (2016-04-18 16:48:55 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as de1d4735291d82380f71a7be88952db1f03bc99e (presubmit successful).
4 years, 8 months ago (2016-04-19 09:04:22 UTC) #5
Johnni Winther
4 years, 8 months ago (2016-04-20 10:12:55 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/behavior.dart:36: default:
On 2016/04/18 16:48:54, Siggi Cherem (dart-lang) wrote:
> do you expect to add more cases in the future?
> 
> If not, switch to an assertion or an `if-else`?

I don't know. Stephen might. Making it an if-else for now.

https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/native...
File pkg/compiler/lib/src/native/enqueue.dart (left):

https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/native...
pkg/compiler/lib/src/native/enqueue.dart:99: final Map<Node, NativeBehavior>
nativeBehaviors =
On 2016/04/18 16:48:54, Siggi Cherem (dart-lang) wrote:
> Great to see this gone! Really nice decoupling of the native behavior from the
> rest of the compiler :-)

Acknowledged.

https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/modelz.dart (right):

https://codereview.chromium.org/1896843002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/modelz.dart:254: // TODO(johnniwinther): This
is need for the token invariant assertion. Find
On 2016/04/18 16:48:54, Siggi Cherem (dart-lang) wrote:
> need => needed

Done.

Powered by Google App Engine
This is Rietveld 408576698