Store and serialize NativeBehavior in TreeElements.

pkg/compiler/lib/src/native/enqueue.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show Queue;
 
 import '../common.dart';
 import '../common/backend_api.dart' show ForeignResolver;
 import '../common/registry.dart' show Registry;
 import '../common/resolution.dart' show Resolution;
@@ skipping 30 matching lines @@
 
   /// Notification of native field.  Adds information from metadata attributes.
   void handleFieldAnnotations(Element field) {}
 
   /// Computes types instantiated due to getting a native field.
   void registerFieldLoad(Element field) {}
 
   /// Computes types instantiated due to setting a native field.
   void registerFieldStore(Element field) {}
 
-  NativeBehavior getNativeBehaviorOf(Send node) => new NativeBehavior();
-
   /// Returns whether native classes are being used.
   bool hasInstantiatedNativeClasses() => false;
 
   /// Emits a summary information using the [log] function.
   void logSummary(log(message)) {}
 
   // Do not use annotations in dart2dart.
   ClassElement get annotationCreatesClass => null;
   ClassElement get annotationReturnsClass => null;
   ClassElement get annotationJsNameClass => null;
@@ skipping 25 matching lines @@
    * Records matched constraints ([SpecialType] or [DartType]).  Once a type
    * constraint has been matched, there is no need to match it again.
    */
   final Set matchedTypeConstraints = new Set();
 
   /// Pending actions.  Classes in [pendingClasses] have action thunks in
   /// [queue] to register the class.
   final queue = new Queue();
   bool flushing = false;
 
-  /// Maps JS foreign calls to their computed native behavior.
-  final Map<Node, NativeBehavior> nativeBehaviors =
-      new Map<Node, NativeBehavior>();
-
   final Enqueuer world;
   final Compiler compiler;
   final bool enableLiveTypeAnalysis;
 
   ClassElement _annotationCreatesClass;
   ClassElement _annotationReturnsClass;
   ClassElement _annotationJsNameClass;
 
   /// Subclasses of [NativeEnqueuerBase] are constructed by the backend.
   NativeEnqueuerBase(this.world, Compiler compiler, this.enableLiveTypeAnalysis)
@@ skipping 374 matching lines @@
   }
 
   void registerFieldLoad(Element field) {
     registerNativeBehavior(NativeBehavior.ofFieldLoad(field, compiler), field);
   }
 
   void registerFieldStore(Element field) {
     registerNativeBehavior(NativeBehavior.ofFieldStore(field, compiler), field);
   }
 
-  NativeBehavior getNativeBehaviorOf(Send node) => nativeBehaviors[node];
-
   processNativeBehavior(NativeBehavior behavior, cause) {
     // TODO(ahe): Is this really a global dependency?
     Registry registry = compiler.globalDependencies;
     bool allUsedBefore = unusedClasses.isEmpty;
     for (var type in behavior.typesInstantiated) {
       if (matchedTypeConstraints.contains(type)) continue;
       matchedTypeConstraints.add(type);
       if (type is SpecialType) {
         if (type == SpecialType.JsObject) {
           backend.registerInstantiatedType(
@@ skipping 98 matching lines @@
 
   /**
    * Handles JS-calls, which can be an instantiation point for types.
    *
    * For example, the following code instantiates and returns native classes
    * that are `_DOMWindowImpl` or a subtype.
    *
    *     JS('_DOMWindowImpl', 'window')
    *
    */
-  void registerJsCall(Send node, ForeignResolver resolver) {
+  NativeBehavior resolveJsCall(Send node, ForeignResolver resolver) {
     NativeBehavior behavior = NativeBehavior.ofJsCall(
         node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
+    // TODO(johnniwinther): Move registration to the world impact application.
     registerNativeBehavior(behavior, node);
-    nativeBehaviors[node] = behavior;
+    return behavior;
   }
 
   /**
    * Handles JS-embedded global calls, which can be an instantiation point for
    * types.
    *
    * For example, the following code instantiates and returns a String class
    *
    *     JS_EMBEDDED_GLOBAL('String', 'foo')
    *
    */
-  void registerJsEmbeddedGlobalCall(Send node, ForeignResolver resolver) {
+  NativeBehavior resolveJsEmbeddedGlobalCall(
+      Send node, ForeignResolver resolver) {
     NativeBehavior behavior = NativeBehavior.ofJsEmbeddedGlobalCall(
         node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
+    // TODO(johnniwinther): Move registration to the world impact application.
     registerNativeBehavior(behavior, node);
-    nativeBehaviors[node] = behavior;
+    return behavior;
   }
 
   /**
    * Handles JS-compiler builtin calls, which can be an instantiation point for
    * types.
    *
    * For example, the following code instantiates and returns a String class
    *
    *     JS_BUILTIN('String', 'int2string', 0)
    *
    */
-  void registerJsBuiltinCall(Send node, ForeignResolver resolver) {
+  NativeBehavior resolveJsBuiltinCall(Send node, ForeignResolver resolver) {
     NativeBehavior behavior = NativeBehavior.ofJsBuiltinCall(
         node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
+    // TODO(johnniwinther): Move registration to the world impact application.
     registerNativeBehavior(behavior, node);
-    nativeBehaviors[node] = behavior;
+    return behavior;
   }
 }
 
 class NativeCodegenEnqueuer extends NativeEnqueuerBase {
   final CodeEmitterTask emitter;
 
   final Set<ClassElement> doneAddSubtypes = new Set<ClassElement>();
 
   NativeCodegenEnqueuer(Enqueuer world, Compiler compiler, this.emitter)
       : super(world, compiler, compiler.options.enableNativeLiveTypeAnalysis);
@@ skipping 45 matching lines @@
     List<Element> directSubtypes =
         emitter.directSubtypes.putIfAbsent(superclass, () => <ClassElement>[]);
     directSubtypes.add(cls);
   }
 
   void logSummary(log(message)) {
     log('Compiled ${registeredClasses.length} native classes, '
         '${unusedClasses.length} native classes omitted.');
   }
 }