Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled
(updateLayout/updateStyle).*.() are not just doing Layout Tree
Construction but also performing Style Resolution. This patch changes
the names of these functions to be more accurate. This rename change
was also mentioned in the Design Doc for splitting up Style Resolution
and  Layout Tree Construction here: bit.ly/24nQ9UQ

This change is not developer facing as the trace event for the part
of the code the Style resolution and Layout Tree Construction is still
called "UpdateLayoutTree" for backwards compatibility.

BUG=595137
Committed: https://crrev.com/52328753422fc25a3815bd58f6eaf8e70f6e27ff
Cr-Commit-Position: refs/heads/master@{#394644}

[nainar, 2016-04-20 23:56:30]

Description was changed from

==========
WIP: Rename Document::updateLayoutTree.*.() to
Document::updateStyleAndLayoutTree.*.()

Currently functions in Document titled Document::updateLayoutTree* are
not just updating the Layout Tree but also performing style recalc. This
patch changes the names of these functions to be more accurate.

BUG=595137
==========

to

==========
WIP: Rename Document::updateLayout.*.() to Document::updateStyleAndLayout.*.()

Currently functions in Document titled Document::updateLayout* are
not just updating the Layout Tree but also performing style recalc. This
patch changes the names of these functions to be more accurate.

BUG=595137
==========

[nainar, 2016-04-20 23:57:46]

nainar@chromium.org changed reviewers:
+ bugsnash@chromium.org

[nainar, 2016-04-20 23:57:47]

Sending to bring to your attention.

[nainar, 2016-04-26 03:43:29]

Description was changed from

==========
WIP: Rename Document::updateLayout.*.() to Document::updateStyleAndLayout.*.()

Currently functions in Document titled Document::updateLayout* are
not just updating the Layout Tree but also performing style recalc. This
patch changes the names of these functions to be more accurate.

BUG=595137
==========

to

==========
Rename Document::updateLayout.*.() to Document::updateStyleAndLayout.*.()

Currently functions in Document titled Document::updateLayout.*.() are
not just doing Layout Tree Construction but also performing Style Recalc. This
patch changes the names of these functions to be more accurate.

BUG=595137
==========

[nainar, 2016-04-26 03:52:38]

nainar@chromium.org changed reviewers:
+ timloh@chromium.org

[nainar, 2016-04-26 03:52:39]

@timloh,

PTAl? This rename change was also mentioned in the Design Doc for splitting up
Style Resolution and Layout Tree Construction here:
https://drive.google.com/open?id=1RlEfhfUnhIEJSgV0nb8AKT4uyWbNsSY_k9uSGTUCQ2I

[nainar, 2016-04-26 05:06:42]

Description was changed from

==========
Rename Document::updateLayout.*.() to Document::updateStyleAndLayout.*.()

Currently functions in Document titled Document::updateLayout.*.() are
not just doing Layout Tree Construction but also performing Style Recalc. This
patch changes the names of these functions to be more accurate.

BUG=595137
==========

to

==========
Rename Document::updateLayout.*.() to Document::updateStyleAndLayout.*.()

Currently functions in Document titled Document::updateLayout.*.() are
not just doing Layout Tree Construction but also performing Style Recalc.
This patch changes the names of these functions to be more accurate. 
This rename change was also mentioned in the Design Doc for splitting 
up Style Resolution and Layout Tree Construction here: 
https://drive.google.com/open?id=1RlEfhfUnhIEJSgV0nb8AKT4uyWbNsSY_k9uSGTUCQ2I

BUG=595137
==========

[Bugs Nash, 2016-04-26 07:25:43]

Also change
- Document::updateLayoutIgnorePendingStylesheetsForNode ->
Document::updateStyleAndLayoutIgnorePendingStylesheetsForNode
- Internals::updateStyleAndReturnAffectedElementCount ->
Internals::updateStyleAndLayoutAndReturnAffectedElementCount
- There’s also some generated code with function names that should be updated,
(see out/Debug/gen/blink/bindings/core/v8/V8Internals.cpp):
 - updateStyleAndReturnAffectedElementCountMethod ->
updateStyleAndLayoutAndReturnAffectedElementCountMethod
 - updateStyleAndReturnAffectedElementCountMethodCallback ->
updateStyleAndLayoutAndReturnAffectedElementCountMethodCallback

[nainar, 2016-04-29 05:35:19]

Description was changed from

==========
Rename Document::updateLayout.*.() to Document::updateStyleAndLayout.*.()

Currently functions in Document titled Document::updateLayout.*.() are
not just doing Layout Tree Construction but also performing Style Recalc.
This patch changes the names of these functions to be more accurate. 
This rename change was also mentioned in the Design Doc for splitting 
up Style Resolution and Layout Tree Construction here: 
https://drive.google.com/open?id=1RlEfhfUnhIEJSgV0nb8AKT4uyWbNsSY_k9uSGTUCQ2I

BUG=595137
==========

to

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled 
(updateLayout/updateStyle).*.() are not just doing Layout Tree 
Construction but also performing Style Recalc. This patch changes the 
names of these functions to be more accurate. This rename change was 
also mentioned in the Design Doc for splitting up Style Resolution and 
Layout Tree Construction here: bit.ly/24nQ9UQ

BUG=595137
==========

[nainar, 2016-04-29 07:56:04]

@bugsnash,

PTAL? Should have all the changes. Also updated the design doc with the
functions that got renamed.

[Bugs Nash, 2016-05-03 05:48:46]

https://codereview.chromium.org/1896793002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js
(right):

https://codereview.chromium.org/1896793002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js:5: // We
need to make sure the console message text is unique so that we don't end up
with repeat count update only
Is this intentional?

https://codereview.chromium.org/1896793002/diff/60001/tools/valgrind/drmemory...
File tools/valgrind/drmemory/suppressions_full.txt (right):

https://codereview.chromium.org/1896793002/diff/60001/tools/valgrind/drmemory...
tools/valgrind/drmemory/suppressions_full.txt:2108:
webcore_shared.dll!blink::Document::updateStyleAndLayoutTree
What does this do? Not necessary for build.

[Bugs Nash, 2016-05-03 05:50:20]

On 2016/05/03 at 05:48:46, Bugs Nash wrote:
>
https://codereview.chromium.org/1896793002/diff/60001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js
(right):
> 
>
https://codereview.chromium.org/1896793002/diff/60001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js:5: // We
need to make sure the console message text is unique so that we don't end up
with repeat count update only
> Is this intentional?
> 
>
https://codereview.chromium.org/1896793002/diff/60001/tools/valgrind/drmemory...
> File tools/valgrind/drmemory/suppressions_full.txt (right):
> 
>
https://codereview.chromium.org/1896793002/diff/60001/tools/valgrind/drmemory...
> tools/valgrind/drmemory/suppressions_full.txt:2108:
webcore_shared.dll!blink::Document::updateStyleAndLayoutTree
> What does this do? Not necessary for build.

lgtm with nit

[nainar, 2016-05-03 07:15:43]

Removed the redundant change

https://codereview.chromium.org/1896793002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js
(right):

https://codereview.chromium.org/1896793002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js:5: // We
need to make sure the console message text is unique so that we don't end up
with repeat count update only
On 2016/05/03 at 05:48:46, Bugs Nash wrote:
> Is this intentional?

No it's an accident. Removing.

[Timothy Loh, 2016-05-04 01:54:58]

https://codereview.chromium.org/1896793002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1896793002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.idl:63: [RaisesException]
unsigned long updateStyleAndLayoutAndReturnAffectedElementCount();
Let's not rename the Internals functions in this patch. I think the new name is
misleading because the functions are returning the number of elements which we
did a style recalc on, but this might not be the same as the number of elements
that got their layout updated.

[nainar, 2016-05-04 07:29:52]

@timloh,

PTAL?

Thanks!

https://codereview.chromium.org/1896793002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/1896793002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.idl:63: [RaisesException]
unsigned long updateStyleAndLayoutAndReturnAffectedElementCount();
On 2016/05/04 at 01:54:58, Timothy Loh wrote:
> Let's not rename the Internals functions in this patch. I think the new name
is misleading because the functions are returning the number of elements which
we did a style recalc on, but this might not be the same as the number of
elements that got their layout updated.

Removed the renames from Internals.

[Timothy Loh, 2016-05-05 05:11:53]

Looks like this change is exposed to developers? The patch description should
mention and give details here.

[nainar, 2016-05-05 05:18:09]

Description was changed from

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled 
(updateLayout/updateStyle).*.() are not just doing Layout Tree 
Construction but also performing Style Recalc. This patch changes the 
names of these functions to be more accurate. This rename change was 
also mentioned in the Design Doc for splitting up Style Resolution and 
Layout Tree Construction here: bit.ly/24nQ9UQ

BUG=595137
==========

to

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled 
(updateLayout/updateStyle).*.() are not just doing Layout Tree 
Construction but also performing Style Resolution. This patch changes 
the names of these functions to be more accurate. This rename change
was also mentioned in the Design Doc for splitting up Style Resolution
and  Layout Tree Construction here: bit.ly/24nQ9UQ

This change is also developer facing as the trace event for the part 
of the code the Style resolution and Layout Tree Construction is now 
called "UpdateStyleAndLayoutTree" instead of "UpdateLayoutTree".

BUG=595137
==========

[nainar, 2016-05-05 05:18:48]

I have added details of the developer facing changes to the patch description.

[Timothy Loh, 2016-05-05 08:32:31]

lgtm as long as that the bots are only red because you need to rebase

[nainar, 2016-05-10 03:14:30]

Looks ready to commit now - needed a rebase. Also some of the bots were acting
funny earlier. Seems to have settled down now. 

Committing.

[nainar, 2016-05-10 03:14:35]

The CQ bit was checked by nainar@chromium.org

[nainar, 2016-05-10 03:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1896793002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-05-10 03:14:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896793002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896793002/140001

[commit-bot: I haz the power, 2016-05-10 03:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 03:24:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nainar, 2016-05-10 03:35:40]

nainar@chromium.org changed reviewers:
+ dmazzoni@chromium.org, junov@chromium.org, samli@chromium.org,
tkent@chromium.org

[nainar, 2016-05-10 03:35:42]

Looking for owners LGTM:

samli: devtools/front_end
dmazzoni: modules/accessibility
junov: modules/canvas2d
tkent: web

Thank you!

[tkent, 2016-05-10 03:43:29]

third_party/WebKit lgtm.  I'm not sure about devtools/.

[samli, 2016-05-10 03:43:58]

samli@chromium.org changed reviewers:
+ caseq@chromium.org

[samli, 2016-05-10 03:44:00]

+caseq for devtools timeline change

https://codereview.chromium.org/1896793002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js
(left):

https://codereview.chromium.org/1896793002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js:61:
UpdateLayoutTree: "UpdateLayoutTree",
I think this might actually need to stick around for backwards compatibility
since timeline can load old timeline files. caseq@ can confirm.

[caseq, 2016-05-10 04:23:20]

On 2016/05/10 03:44:00, samli wrote:
> +caseq for devtools timeline change
> 
>
https://codereview.chromium.org/1896793002/diff/140001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js
> (left):
> 
>
https://codereview.chromium.org/1896793002/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js:61:
> UpdateLayoutTree: "UpdateLayoutTree",
> I think this might actually need to stick around for backwards compatibility
> since timeline can load old timeline files. caseq@ can confirm.

Thanks, Sam -- this is correct! We should keep both the name of the trace event
and the related constant in TimelineModel.js for compatibility reasons. If the
urge to rename is strong, please add handling for old name as it was previously
done for StyleRecalculate.

[nainar, 2016-05-11 05:12:50]

Description was changed from

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled 
(updateLayout/updateStyle).*.() are not just doing Layout Tree 
Construction but also performing Style Resolution. This patch changes 
the names of these functions to be more accurate. This rename change
was also mentioned in the Design Doc for splitting up Style Resolution
and  Layout Tree Construction here: bit.ly/24nQ9UQ

This change is also developer facing as the trace event for the part 
of the code the Style resolution and Layout Tree Construction is now 
called "UpdateStyleAndLayoutTree" instead of "UpdateLayoutTree".

BUG=595137
==========

to

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled 
(updateLayout/updateStyle).*.() are not just doing Layout Tree 
Construction but also performing Style Resolution. This patch changes 
the names of these functions to be more accurate. This rename change
was also mentioned in the Design Doc for splitting up Style Resolution
and  Layout Tree Construction here: bit.ly/24nQ9UQ

This change is not developer facing as the trace event for the part 
of the code the Style resolution and Layout Tree Construction is still 
called "UpdateLayoutTree" for backwards compatibility.

BUG=595137
==========

[nainar, 2016-05-11 05:15:58]

Made the changes to make sure that the trace event stays the same. There are no
changes made in devtools area of the code now. 

@timloh and @tkent: PTAL if need be?

@dmazzoni and @junov for OWNERS LGTM for modules.

Thank you!

[Justin Novosad, 2016-05-16 17:25:00]

lgtm for modules/2dcanvas

[dmazzoni, 2016-05-17 16:22:36]

lgtm for accessibility

[nainar, 2016-05-19 02:39:38]

Thanks for the reviews. Rebasing and committing.

[nainar, 2016-05-19 02:39:47]

The CQ bit was checked by nainar@chromium.org

[nainar, 2016-05-19 02:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
timloh@chromium.org, bugsnash@chromium.org, junov@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1896793002/#ps200001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 02:40:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896793002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896793002/200001

[commit-bot: I haz the power, 2016-05-19 03:04:17]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-05-19 03:05:52]

Description was changed from

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled 
(updateLayout/updateStyle).*.() are not just doing Layout Tree 
Construction but also performing Style Resolution. This patch changes 
the names of these functions to be more accurate. This rename change
was also mentioned in the Design Doc for splitting up Style Resolution
and  Layout Tree Construction here: bit.ly/24nQ9UQ

This change is not developer facing as the trace event for the part 
of the code the Style resolution and Layout Tree Construction is still 
called "UpdateLayoutTree" for backwards compatibility.

BUG=595137
==========

to

==========
Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Currently functions in Document and other classes titled
(updateLayout/updateStyle).*.() are not just doing Layout Tree
Construction but also performing Style Resolution. This patch changes
the names of these functions to be more accurate. This rename change
was also mentioned in the Design Doc for splitting up Style Resolution
and  Layout Tree Construction here: bit.ly/24nQ9UQ

This change is not developer facing as the trace event for the part
of the code the Style resolution and Layout Tree Construction is still
called "UpdateLayoutTree" for backwards compatibility.

BUG=595137

Committed: https://crrev.com/52328753422fc25a3815bd58f6eaf8e70f6e27ff
Cr-Commit-Position: refs/heads/master@{#394644}
==========

[commit-bot: I haz the power, 2016-05-19 03:05:54]

Patchset 11 (id:??) landed as
https://crrev.com/52328753422fc25a3815bd58f6eaf8e70f6e27ff
Cr-Commit-Position: refs/heads/master@{#394644}