third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index a361cba58c125d05d3af5b9eb1a803a0e67f4aa6..e114c9e0509a3db26290a4db01f7e1c69da6571d 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -289,7 +289,7 @@ HTMLElement* ReplacementFragment::insertFragmentForTestRendering(Element* rootEd

holder->appendChild(m_fragment);

rootEditableElement->appendChild(holder);

- m_document->updateLayoutIgnorePendingStylesheets();

+ m_document->updateStyleAndLayoutIgnorePendingStylesheets();

return holder;

}

@@ -736,7 +736,7 @@ static inline bool nodeHasVisibleLayoutText(Text& text)

void ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds(InsertedNodes& insertedNodes)

{

- document().updateLayoutIgnorePendingStylesheets();

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

Node* lastLeafInserted = insertedNodes.lastLeafInserted();

if (lastLeafInserted && lastLeafInserted->isTextNode() && !nodeHasVisibleLayoutText(toText(*lastLeafInserted))

@@ -1458,7 +1458,7 @@ void ReplaceSelectionCommand::addSpacesForSmartReplace(EditingState* editingStat

}

- document().updateLayout();

+ document().updateStyleAndLayout();

Position startDownstream = mostForwardCaretPosition(startOfInsertedContent.deepEquivalent());

Node* startNode = startDownstream.computeNodeAfterPosition();