plumb API for analytic rrect blur

plumb API for analytic rrect blur

BUG=skia:2281
Committed: http://code.google.com/p/skia/source/detail?r=13733

[humper, 2014-03-10 15:18:06]

ptal; CPU plumbing

[bsalomon, 2014-03-10 16:03:09]

seems ok to me, but I'm not familiar with code. Adding Mike.

https://codereview.chromium.org/189663012/diff/1/src/effects/SkBlurMask.h
File src/effects/SkBlurMask.h (right):

https://codereview.chromium.org/189663012/diff/1/src/effects/SkBlurMask.h#new...
src/effects/SkBlurMask.h:59: SK_ATTR_DEPRECATED("use sigma version")
Do we need to add the deprecated version?

[reed1, 2014-03-10 16:08:35]

Even as a shim, there doesn't seem to be enough here to marginally test. Don't
we need a new virtual on SkMaskFilter to pass in the rrect? Seems like that
could show calling the new SkBlurMask entry-point, getting a false, and then
falling-through to filterPath...

https://codereview.chromium.org/189663012/diff/1/src/effects/SkBlurMask.h
File src/effects/SkBlurMask.h (right):

https://codereview.chromium.org/189663012/diff/1/src/effects/SkBlurMask.h#new...
src/effects/SkBlurMask.h:59: SK_ATTR_DEPRECATED("use sigma version")
On 2014/03/10 16:03:09, bsalomon wrote:
> Do we need to add the deprecated version?

-1

no deprecated version

[humper, 2014-03-10 17:46:53]

On 2014/03/10 16:08:35, reed1 wrote:
> Even as a shim, there doesn't seem to be enough here to marginally test. Don't
> we need a new virtual on SkMaskFilter to pass in the rrect? Seems like that
> could show calling the new SkBlurMask entry-point, getting a false, and then
> falling-through to filterPath...
> 
> https://codereview.chromium.org/189663012/diff/1/src/effects/SkBlurMask.h
> File src/effects/SkBlurMask.h (right):
> 
>
https://codereview.chromium.org/189663012/diff/1/src/effects/SkBlurMask.h#new...
> src/effects/SkBlurMask.h:59: SK_ATTR_DEPRECATED("use sigma version")
> On 2014/03/10 16:03:09, bsalomon wrote:
> > Do we need to add the deprecated version?
> 
> -1
> 
> no deprecated version

I didn't think that we would need a new virtual on SkMaskFilter because the new
code is invoked from the existing filterRRectToNine.  We might need a new entry
point on the GPU; I was going to try to land that plumbing separately.

Will remove deprecated stuff.

[humper, 2014-03-10 17:52:38]

Deprecated functions removed.

[reed1, 2014-03-10 19:18:56]

lgtm

[humper, 2014-03-10 19:35:29]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-03-10 19:35:33]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/189663012/20001

[commit-bot: I haz the power, 2014-03-10 21:42:10]

Change committed as 13733