Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/installer/util/scoped_user_protocol_entry.h

Issue 1896513002: Fix registerProtocolHandler implementation on Windows 8 and 10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix clang compilation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/installer/util/scoped_user_protocol_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/scoped_user_protocol_entry.h
diff --git a/chrome/installer/util/scoped_user_protocol_entry.h b/chrome/installer/util/scoped_user_protocol_entry.h
index abd6056476f234c393b54bd97f1019b0a775b67f..0ca2b5ef040a80ab9f1dd6c58910cec36ce7ee1c 100644
--- a/chrome/installer/util/scoped_user_protocol_entry.h
+++ b/chrome/installer/util/scoped_user_protocol_entry.h
@@ -10,17 +10,17 @@
class RegistryEntry;
-// Windows 8 shows the "No apps are installed to open this type of link(http)"
-// dialog when choosing default browser under certain circumstances. Under
-// these circumstances, it appears that ensuring the existance of the
-// HKCU\Software\Classes\http key with an empty "URL Protocol" value is
-// sufficient to make the dialog contain the usual list of registered browsers.
-// This class creates this key and value in its constructor if needed, and
-// cleans them up in its destructor if no other values or subkeys were created
-// in the meantime. For details, see https://crbug.com/569151.
+// Windows 8 shows the "No apps are installed to open this type of link"
+// dialog when choosing a default handler for a |protocol| under certain
+// circumstances. Under these circumstances, it appears that ensuring the
+// existance of the HKCU\Software\Classes\<protocol> key with an empty "URL
+// Protocol" value is sufficient to make the dialog contain the usual list of
+// registered browsers. This class creates this key and value in its constructor
+// if needed, and cleans them up in its destructor if no other values or subkeys
+// were created in the meantime. For details, see https://crbug.com/569151.
class ScopedUserProtocolEntry {
public:
- ScopedUserProtocolEntry();
+ explicit ScopedUserProtocolEntry(const wchar_t* protocol);
~ScopedUserProtocolEntry();
private:
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/installer/util/scoped_user_protocol_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698