chrome/installer/util/scoped_user_protocol_entry.cc - Issue 1896513002: Fix registerProtocolHandler implementation on Windows 8 and 10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/scoped_user_protocol_entry.cc

Issue 1896513002: Fix registerProtocolHandler implementation on Windows 8 and 10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix clang compilation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/installer/util/scoped_user_protocol_entry.h ('k') | chrome/installer/util/scoped_user_protocol_entry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/scoped_user_protocol_entry.cc

diff --git a/chrome/installer/util/scoped_user_protocol_entry.cc b/chrome/installer/util/scoped_user_protocol_entry.cc

index 8dc51e40ab3a09ddf38644b1b6659afaaafad775..3aa7f0211d40b6d3139a971e1a8f6500694f7ff5 100644

--- a/chrome/installer/util/scoped_user_protocol_entry.cc

+++ b/chrome/installer/util/scoped_user_protocol_entry.cc

@@ -10,9 +10,9 @@

#include "chrome/installer/util/registry_entry.h"

#include "chrome/installer/util/shell_util.h"

-ScopedUserProtocolEntry::ScopedUserProtocolEntry() {

+ScopedUserProtocolEntry::ScopedUserProtocolEntry(const wchar_t* protocol) {

entries_.push_back(new RegistryEntry(

- base::FilePath(ShellUtil::kRegClasses).Append(L"http").value(),

+ base::FilePath(ShellUtil::kRegClasses).Append(protocol).value(),

ShellUtil::kRegUrlProtocol, base::string16()));

if (!entries_.back()->KeyExistsInRegistry(RegistryEntry::LOOK_IN_HKCU) &&

ShellUtil::AddRegistryEntries(HKEY_CURRENT_USER, entries_)) {

« no previous file with comments | « chrome/installer/util/scoped_user_protocol_entry.h ('k') | chrome/installer/util/scoped_user_protocol_entry_unittest.cc » ('j') | no next file with comments »