Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1896483002: Removed DeviceDataManagerX11::scrollclass_devices_ (Closed)

Created:
4 years, 8 months ago by Will Shackleton
Modified:
4 years, 8 months ago
Reviewers:
bokan, dtapuska, sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed DeviceDataManagerX11::scrollclass_devices_ This field isn't needed, and goes against the idea that a mouse either supports scroll classes entirely or not at all. Instead we should use logic that checks whether a device supports horizontal, vertical or both scroll classes. I also fixed some logic that could have passed an invalid validator ID into XIMaskIsSet---this new check covers the check removed above it. BUG=596013 Committed: https://crrev.com/b89e8ac7021fcee56c7cc34fd077eac253c99d0b Cr-Commit-Position: refs/heads/master@{#388208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M ui/events/devices/x11/device_data_manager_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Will Shackleton
4 years, 8 months ago (2016-04-15 17:07:02 UTC) #4
sadrul
lgtm
4 years, 8 months ago (2016-04-19 14:25:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896483002/1
4 years, 8 months ago (2016-04-19 14:29:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 15:14:55 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:12:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b89e8ac7021fcee56c7cc34fd077eac253c99d0b
Cr-Commit-Position: refs/heads/master@{#388208}

Powered by Google App Engine
This is Rietveld 408576698