Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 1896463002: Merge to M51: Accessible location change events need to update internal data structure (Closed)

Created:
4 years, 8 months ago by dmazzoni
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge to M51: Accessible location change events need to update internal data structure In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire fewer Android events when objects change location. While this achieved its desired goal, it sometimes didn't update the internal data structure with the new locations, leading to the location updates containing stale data. This change refactors the code so that the internal data structure is always updated first, then a second function is called to send events, which can be deferred on Android. BUG=602739, 588889 Review URL: https://codereview.chromium.org/1884723003 Cr-Commit-Position: refs/heads/master@{#387488} (cherry picked from commit 8196ad3aa5a432169904cb72d57d760719df3e4a) Committed: https://chromium.googlesource.com/chromium/src/+/e78110fb18421d81679d5ee745c78b68408ae0ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +8 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +10 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmazzoni
4 years, 8 months ago (2016-04-15 16:47:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e78110fb18421d81679d5ee745c78b68408ae0ad.

Powered by Google App Engine
This is Rietveld 408576698