Accessible location change events need to update internal data structure

Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739, 588889
Committed: https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a
Cr-Commit-Position: refs/heads/master@{#387488}

[dmazzoni, 2016-04-12 20:03:28]

Description was changed from

==========
Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739
==========

to

==========
Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739,588889
==========

[dmazzoni, 2016-04-12 20:03:28]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2016-04-13 22:52:20]

https://codereview.chromium.org/1884723003/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager.cc (right):

https://codereview.chromium.org/1884723003/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager.cc:396: }
I expected a call to SendLocationChangeEvents here.

[dmazzoni, 2016-04-14 18:19:47]

https://codereview.chromium.org/1884723003/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager.cc (right):

https://codereview.chromium.org/1884723003/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager.cc:396: }
On 2016/04/13 22:52:20, David Tseng wrote:
> I expected a call to SendLocationChangeEvents here.

Good catch, done.

[David Tseng, 2016-04-14 22:32:17]

lgtm

[dmazzoni, 2016-04-14 23:08:11]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-04-14 23:08:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/1884723003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-14 23:08:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884723003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884723003/40001

[commit-bot: I haz the power, 2016-04-15 00:18:59]

Description was changed from

==========
Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739,588889
==========

to

==========
Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739,588889
==========

[commit-bot: I haz the power, 2016-04-15 00:19:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 00:19:56]

Description was changed from

==========
Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739,588889
==========

to

==========
Accessible location change events need to update internal data structure

In http://crrev.com/377045 (http://crbug.com/588889), we tried to fire
fewer Android events when objects change location. While this achieved
its desired goal, it sometimes didn't update the internal data
structure with the new locations, leading to the location updates
containing stale data.

This change refactors the code so that the internal data structure is
always updated first, then a second function is called to send events,
which can be deferred on Android.

BUG=602739,588889

Committed: https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a
Cr-Commit-Position: refs/heads/master@{#387488}
==========

[commit-bot: I haz the power, 2016-04-15 00:19:57]

Patchset 3 (id:??) landed as
https://crrev.com/8196ad3aa5a432169904cb72d57d760719df3e4a
Cr-Commit-Position: refs/heads/master@{#387488}