[libfuzzer] Update documentation on UBSan options and Upload Corpus section.

[libfuzzer] Update documentation on UBSan options and Upload Corpus section.

R=aizatsky@chromium.org, ochang@chromium.org, mbarbella@chromium.org
BUG=595751
Committed: https://crrev.com/5a2604d4cbd666cf32cba28dca8af6157f096f4e
Cr-Commit-Position: refs/heads/master@{#388731}

[Martin Barbella, 2016-04-19 15:44:41]

LGTM with a few wording nits

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
File testing/libfuzzer/clusterfuzz.md (right):

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
testing/libfuzzer/clusterfuzz.md:39: There are two types of corpus used by
libFuzzers at ClusterFuzz:
ClusterFuzz uses two corpus types with libFuzzer:

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
testing/libfuzzer/clusterfuzz.md:48: Literally, a fuzzer has two input corpus
directories (seed and general), but
Remove "Literally, "
(seed and general), -> , seed and general,

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
testing/libfuzzer/clusterfuzz.md:51: To upload seed corpus for libFuzzer being
run at ClusterFuzz:
for a libFuzzer

[Oliver Chang, 2016-04-19 16:05:07]

LGTM with a question:

What about the seed corpus support in GC that Mike added here
(https://codereview.chromium.org/1768743002)? Do we have documentation for that
too?

While GCS static corpus has the advantage that we can upload more and larger
files, I'm not sure if we should keep both around, as that would probably cause
some confusion...

[Oliver Chang, 2016-04-19 16:05:28]

On 2016/04/19 16:05:07, Oliver Chang wrote:
> LGTM with a question:
> 
> What about the seed corpus support in GC that Mike added here
> (https://codereview.chromium.org/1768743002) Do we have documentation for that
> too?

s/in GC/in GN/
> 
> While GCS static corpus has the advantage that we can upload more and larger
> files, I'm not sure if we should keep both around, as that would probably
cause
> some confusion...

[mmoroz, 2016-04-19 17:31:06]

On 2016/04/19 16:05:07, Oliver Chang wrote:
> LGTM with a question:
> 
> What about the seed corpus support in GC that Mike added here
> (https://codereview.chromium.org/1768743002) Do we have documentation for that
> too?
> 
> While GCS static corpus has the advantage that we can upload more and larger
> files, I'm not sure if we should keep both around, as that would probably
cause
> some confusion...

Good point, probably I should add a couple of lines on that. I'm afraid that we
have to use both, since we couldn't agree on one solution previously. We ended
up with two points:
- it is good to have seed corpus in the repository
- in some cases we don't want to share seed corpus and need to store it
somewhere else (like GCS bucket accessible by googlers only)

[mmoroz, 2016-04-19 17:33:12]

On 2016/04/19 17:31:06, mmoroz wrote:
> On 2016/04/19 16:05:07, Oliver Chang wrote:
> > LGTM with a question:
> > 
> > What about the seed corpus support in GC that Mike added here
> > (https://codereview.chromium.org/1768743002) Do we have documentation for
that
> > too?
> > 
> > While GCS static corpus has the advantage that we can upload more and larger
> > files, I'm not sure if we should keep both around, as that would probably
> cause
> > some confusion...
> 
> Good point, probably I should add a couple of lines on that. I'm afraid that
we
> have to use both, since we couldn't agree on one solution previously. We ended
> up with two points:
> - it is good to have seed corpus in the repository
> - in some cases we don't want to share seed corpus and need to store it
> somewhere else (like GCS bucket accessible by googlers only)

But yes, it will be confusing. Let's say that for public corpus people should
use repository and .GN build option. For some private or large files it would be
better to use static corpus at GCS.

[mmoroz, 2016-04-19 17:46:36]

Thanks for comments, PTAL :)

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
File testing/libfuzzer/clusterfuzz.md (right):

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
testing/libfuzzer/clusterfuzz.md:39: There are two types of corpus used by
libFuzzers at ClusterFuzz:
On 2016/04/19 15:44:41, Martin Barbella wrote:
> ClusterFuzz uses two corpus types with libFuzzer:

Done.

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
testing/libfuzzer/clusterfuzz.md:48: Literally, a fuzzer has two input corpus
directories (seed and general), but
On 2016/04/19 15:44:41, Martin Barbella wrote:
> Remove "Literally, "
> (seed and general), -> , seed and general,

Done.

https://codereview.chromium.org/1896123002/diff/1/testing/libfuzzer/clusterfu...
testing/libfuzzer/clusterfuzz.md:51: To upload seed corpus for libFuzzer being
run at ClusterFuzz:
On 2016/04/19 15:44:41, Martin Barbella wrote:
> for a libFuzzer

Done.

[Martin Barbella, 2016-04-19 18:29:23]

lgtm

[aizatsky, 2016-04-19 18:42:43]

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/clust...
File testing/libfuzzer/clusterfuzz.md (right):

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/clust...
testing/libfuzzer/clusterfuzz.md:53: #### Chromium repository
Let's move this section to efficient_fuzzing.

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/getti...
File testing/libfuzzer/getting_started.md (right):

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/getti...
testing/libfuzzer/getting_started.md:114:
UBSAN_OPTIONS=symbolize=1:halt_on_error=1:print_stacktrace=1 ./fuzzer
<corpus_directory_or_single_testcase_path>
FYI: https://bugs.chromium.org/p/chromium/issues/detail?id=604823

[mmoroz, 2016-04-20 12:38:20]

Moved instructions on corpus uploading to efficient_fuzzer.

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/clust...
File testing/libfuzzer/clusterfuzz.md (right):

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/clust...
testing/libfuzzer/clusterfuzz.md:53: #### Chromium repository
On 2016/04/19 18:42:43, aizatsky wrote:
> Let's move this section to efficient_fuzzing.

Done.

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/getti...
File testing/libfuzzer/getting_started.md (right):

https://codereview.chromium.org/1896123002/diff/20001/testing/libfuzzer/getti...
testing/libfuzzer/getting_started.md:114:
UBSAN_OPTIONS=symbolize=1:halt_on_error=1:print_stacktrace=1 ./fuzzer
<corpus_directory_or_single_testcase_path>
On 2016/04/19 18:42:43, aizatsky wrote:
> FYI: https://bugs.chromium.org/p/chromium/issues/detail?id=604823

Acknowledged.

[aizatsky, 2016-04-20 18:46:12]

lgtm

[mmoroz, 2016-04-21 08:29:33]

The CQ bit was checked by mmoroz@chromium.org

[mmoroz, 2016-04-21 08:29:34]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
mbarbella@chromium.org
Link to the patchset: https://codereview.chromium.org/1896123002/#ps40001
(title: "Move instructions for corpus uploading into efficient_fuzzer.")

[commit-bot: I haz the power, 2016-04-21 08:29:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896123002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896123002/40001

[commit-bot: I haz the power, 2016-04-21 10:08:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:33:02]

Description was changed from

==========
[libfuzzer] Update documentation on UBSan options and Upload Corpus section.

R=aizatsky@chromium.org, ochang@chromium.org, mbarbella@chromium.org
BUG=595751
==========

to

==========
[libfuzzer] Update documentation on UBSan options and Upload Corpus section.

R=aizatsky@chromium.org, ochang@chromium.org, mbarbella@chromium.org
BUG=595751

Committed: https://crrev.com/5a2604d4cbd666cf32cba28dca8af6157f096f4e
Cr-Commit-Position: refs/heads/master@{#388731}
==========

[commit-bot: I haz the power, 2016-04-22 19:33:03]

Patchset 3 (id:??) landed as
https://crrev.com/5a2604d4cbd666cf32cba28dca8af6157f096f4e
Cr-Commit-Position: refs/heads/master@{#388731}