Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1768743002:
[libfuzzer] in-vcs corpus support. (Closed)
Description[libfuzzer] in-vcs corpus support.
Adding corpus attribute to fuzzer_test rule.
If present it should be a directory with corpus files. During the build
corpus will be archived into <fuzzer>_corpus.zip file next to the <fuzzer>
binary.
BUG=569020
Committed: https://crrev.com/198e3021415dc3c72087a82c3469b70abcb4afc0
Cr-Commit-Position: refs/heads/master@{#379910}
Patch Set 1 #Patch Set 2 : nits #
Total comments: 8
Patch Set 3 : review #Patch Set 4 : fixing unused attribute error #Patch Set 5 : removing dep from resulting binary #Patch Set 6 : making sure 2nd build doesn't build anything. #
Messages
Total messages: 31 (16 generated)
Description was changed from ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus would be archived into <fuzzer>_corpus.zip file next to <fuzzer> binary. BUG=569020 ========== to ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus would be archived into <fuzzer>_corpus.zip file next to <fuzzer> binary. BUG=569020 ==========
aizatsky@chromium.org changed reviewers: + davidben@chromium.org, inferno@chromium.org, kcc@chromium.org, mmoroz@chromium.org
Description was changed from ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus would be archived into <fuzzer>_corpus.zip file next to <fuzzer> binary. BUG=569020 ========== to ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus will be archived into <fuzzer>_corpus.zip file next to the <fuzzer> binary. BUG=569020 ==========
https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... File testing/libfuzzer/archive_corpus.py (right): https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... testing/libfuzzer/archive_corpus.py:3: # Copyright (c) 2015 The Chromium Authors. All rights reserved. There is no "(c)" now, 2015 -> 2016. Looks like we also need to update this header in gen_fuzzer_config.py. https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... testing/libfuzzer/archive_corpus.py:28: with open(args.depfile, 'w') as depfile: Do we need this .d file? On ClusterFuzz side we can check existence of zip-archive and use it together with corpus from GCS. https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... testing/libfuzzer/archive_corpus.py:33: print(" ", full_filename, end="", file=depfile) Seems that this call will write strings like "<space><space><filepath>" into one line of depfile. Is it expected format? https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/fuzze... File testing/libfuzzer/fuzzer_test.gni (right): https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/fuzze... testing/libfuzzer/fuzzer_test.gni:19: # - corpus - a directory with seed corpus. May be let's use |seed_corpus| option name and the same suffix for zip-archive name (line 55)? Just to make more explicit that it is a "seed corpus" - some testcases stored in repository, not all "corpus" we have and we use.
third_party/boringssl lgtm (Oh, excellent. I was going to ask one of you this morning how to upload the new client and server corpuses to CF, but if you all do it automatically, that saves me some trouble!)
On 2016/03/07 15:47:00, davidben wrote: > third_party/boringssl lgtm > > (Oh, excellent. I was going to ask one of you this morning how to upload the new > client and server corpuses to CF, but if you all do it automatically, that saves > me some trouble!) Actually we've also uploaded new corpus manually to GCS bucket used by CF, but this will help us to avoid manual uploading in future :)
https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... File testing/libfuzzer/archive_corpus.py (right): https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... testing/libfuzzer/archive_corpus.py:3: # Copyright (c) 2015 The Chromium Authors. All rights reserved. On 2016/03/07 14:08:55, mmoroz wrote: > There is no "(c)" now, 2015 -> 2016. > > Looks like we also need to update this header in gen_fuzzer_config.py. Done. https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... testing/libfuzzer/archive_corpus.py:28: with open(args.depfile, 'w') as depfile: On 2016/03/07 14:08:55, mmoroz wrote: > Do we need this .d file? On ClusterFuzz side we can check existence of > zip-archive and use it together with corpus from GCS. This file is needed for gn/ninja. I've also added a dependency to fuzzer binary, so that corpus archive gets rebuilt. https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/archi... testing/libfuzzer/archive_corpus.py:33: print(" ", full_filename, end="", file=depfile) On 2016/03/07 14:08:55, mmoroz wrote: > Seems that this call will write strings like "<space><space><filepath>" into one > line of depfile. Is it expected format? Number of spaces is irrelevant. The format is : <file_name> : <dep1> <dep2> .... https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/fuzze... File testing/libfuzzer/fuzzer_test.gni (right): https://codereview.chromium.org/1768743002/diff/20001/testing/libfuzzer/fuzze... testing/libfuzzer/fuzzer_test.gni:19: # - corpus - a directory with seed corpus. On 2016/03/07 14:08:55, mmoroz wrote: > May be let's use |seed_corpus| option name and the same suffix for zip-archive > name (line 55)? Just to make more explicit that it is a "seed corpus" - some > testcases stored in repository, not all "corpus" we have and we use. Done.
LGTM, Thanks!
The CQ bit was checked by mmoroz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from davidben@chromium.org Link to the patchset: https://codereview.chromium.org/1768743002/#ps40001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768743002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by aizatsky@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org, davidben@chromium.org Link to the patchset: https://codereview.chromium.org/1768743002/#ps60001 (title: "fixing unused attribute error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768743002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aizatsky@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org, davidben@chromium.org Link to the patchset: https://codereview.chromium.org/1768743002/#ps80001 (title: "removing dep from resulting binary")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768743002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768743002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aizatsky@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org, davidben@chromium.org Link to the patchset: https://codereview.chromium.org/1768743002/#ps100001 (title: "making sure 2nd build doesn't build anything.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768743002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768743002/100001
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus will be archived into <fuzzer>_corpus.zip file next to the <fuzzer> binary. BUG=569020 ========== to ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus will be archived into <fuzzer>_corpus.zip file next to the <fuzzer> binary. BUG=569020 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus will be archived into <fuzzer>_corpus.zip file next to the <fuzzer> binary. BUG=569020 ========== to ========== [libfuzzer] in-vcs corpus support. Adding corpus attribute to fuzzer_test rule. If present it should be a directory with corpus files. During the build corpus will be archived into <fuzzer>_corpus.zip file next to the <fuzzer> binary. BUG=569020 Committed: https://crrev.com/198e3021415dc3c72087a82c3469b70abcb4afc0 Cr-Commit-Position: refs/heads/master@{#379910} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/198e3021415dc3c72087a82c3469b70abcb4afc0 Cr-Commit-Position: refs/heads/master@{#379910} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
