Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 1896113003: [tools/perf] Update users of action_runner to directly referencing it from tab.action_runner field (Closed)

Created:
4 years, 8 months ago by nednguyen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Update users of action_runner to directly referencing it from tab.action_runner field BUG=604861 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/095bc6d6946dff2a63c1e6f1bc00df141accbac1 Cr-Commit-Position: refs/heads/master@{#388408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M tools/perf/benchmarks/service_worker.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/perf/measurements/blink_style.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/perf/measurements/oilpan_gc_times.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
nednguyen
4 years, 8 months ago (2016-04-19 21:10:56 UTC) #3
nednguyen
Note that I cannot update https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/chrome_login.py&l=47 to reference action_runner directly yet, because the gaia_context is ...
4 years, 8 months ago (2016-04-19 21:12:07 UTC) #4
eakuefner
lgtm
4 years, 8 months ago (2016-04-19 21:20:57 UTC) #5
aiolos (Not reviewing)
lgtm
4 years, 8 months ago (2016-04-19 21:21:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896113003/1
4 years, 8 months ago (2016-04-19 21:30:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/150)
4 years, 8 months ago (2016-04-20 02:24:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896113003/1
4 years, 8 months ago (2016-04-20 02:36:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 02:41:21 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:12 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/095bc6d6946dff2a63c1e6f1bc00df141accbac1
Cr-Commit-Position: refs/heads/master@{#388408}

Powered by Google App Engine
This is Rietveld 408576698