Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1840)

Unified Diff: tools/perf/benchmarks/service_worker.py

Issue 1896113003: [tools/perf] Update users of action_runner to directly referencing it from tab.action_runner field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/blink_style.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/service_worker.py
diff --git a/tools/perf/benchmarks/service_worker.py b/tools/perf/benchmarks/service_worker.py
index 8542e540f1ba11a85d0e54f524969dd240072f85..6cef574cb9ed7d87c5480203ece87c8a90ea2a2a 100644
--- a/tools/perf/benchmarks/service_worker.py
+++ b/tools/perf/benchmarks/service_worker.py
@@ -9,7 +9,6 @@ import re
from core import perf_benchmark
from telemetry.core import util
-from telemetry.page import action_runner
from telemetry.page import page_test
from telemetry.timeline import async_slice as async_slice_module
from telemetry.timeline import slice as slice_module
@@ -105,12 +104,11 @@ class _ServiceWorkerMeasurement(page_test.PageTest):
self._speed_index.Start(page, tab)
def ValidateAndMeasurePage(self, page, tab, results):
- runner = action_runner.ActionRunner(tab)
# timeline_controller requires creation of at least a single interaction
# record. service_worker should be refactored to follow the
# timeline_based_measurement or it should not re-use timeline_controller
# logic for start & stop tracing.
- with runner.CreateInteraction('_DummyInteraction'):
+ with tab.action_runner.CreateInteraction('_DummyInteraction'):
pass
tab.WaitForDocumentReadyStateToBeComplete(40)
self._timeline_controller.Stop(tab, results)
« no previous file with comments | « no previous file | tools/perf/measurements/blink_style.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698