chrome/common/chrome_switches.cc - Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_switches.cc

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: For landing Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_switches.cc

diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc

index c71f68663b70a15a329bfc59bc3137f0647595fb..cae71f76a93ec4ce7bffc4f1a8ba17a9fcfc286b 100644

--- a/chrome/common/chrome_switches.cc

+++ b/chrome/common/chrome_switches.cc

@@ -1315,8 +1315,7 @@ const char kSigninProcess[] = "signin-process";

const char kSilentDebuggerExtensionAPI[] = "silent-debugger-extension-api";

// Changes the DCHECKS to dump memory and continue instead of displaying error

-// dialog. This is valid only in Release mode when --enable-dcheck is

-// specified.

+// dialog. This is valid only in Release mode when gyp dcheck_always_on=1.

const char kSilentDumpOnDCHECK[] = "silent-dump-on-dcheck";

// Causes Chrome to launch without opening any windows by default. Useful if

« no previous file with comments | « build/common.gypi ('k') | chrome/common/logging_chrome.cc » ('j') | no next file with comments »