Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: build/common.gypi

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For landing Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging_unittest.cc ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e2c383ead8c19b1076c91a8771a6c1306ced8002..56a8c5d19d5d92c0cfe96b6bbf3ecda2d7c1d4b1 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -264,15 +264,9 @@
# on compile-only bots).
'fastbuild%': 0,
- # Set to 1 to enable dcheck in release without having to use the flag.
+ # Set to 1 to enable dcheck in release.
'dcheck_always_on%': 0,
- # Set to 1 to make a build that logs like an official build, but is not
- # necessarily an official build, ie DCHECK and DLOG are disabled and
- # removed completely in release builds, to minimize binary footprint.
- # Note: this setting is ignored if buildtype=="Official".
- 'logging_like_official_build%': 0,
-
# Set to 1 to make a build that disables unshipped tracing events.
# Note: this setting is ignored if buildtype=="Official".
'tracing_like_official_build%': 0,
@@ -911,7 +905,6 @@
'image_loader_extension%': '<(image_loader_extension)',
'fastbuild%': '<(fastbuild)',
'dcheck_always_on%': '<(dcheck_always_on)',
- 'logging_like_official_build%': '<(logging_like_official_build)',
'tracing_like_official_build%': '<(tracing_like_official_build)',
'python_ver%': '<(python_ver)',
'arm_version%': '<(arm_version)',
@@ -2360,9 +2353,6 @@
['dcheck_always_on!=0', {
'defines': ['DCHECK_ALWAYS_ON=1'],
}], # dcheck_always_on!=0
- ['logging_like_official_build!=0', {
- 'defines': ['LOGGING_IS_OFFICIAL_BUILD=1'],
- }], # logging_like_official_build!=0
['tracing_like_official_build!=0', {
'defines': ['TRACING_IS_OFFICIAL_BUILD=1'],
}], # tracing_like_official_build!=0
« no previous file with comments | « base/logging_unittest.cc ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698