Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only

base/i18n/streaming_utf8_validator.cc

Index: base/i18n/streaming_utf8_validator.cc
diff --git a/base/i18n/streaming_utf8_validator.cc b/base/i18n/streaming_utf8_validator.cc
index 3838c9512434f74db4169969a101de3be265234c..1179e835de8594f1090dfceb1c6c716877704804 100644
--- a/base/i18n/streaming_utf8_validator.cc
+++ b/base/i18n/streaming_utf8_validator.cc
@@ -15,8 +15,7 @@ namespace base {
 namespace {
 
 uint8 StateTableLookup(uint8 offset) {
-  // Skip the bounds check on non-debug builds so that it isn't necessary to set
-  // LOGGING_IS_OFFICIAL_BUILD just to do a performance test.
+  // Skip the bounds check on non-debug builds.
   if (logging::DEBUG_MODE)

[Xianzhu, 2014/03/07 22:40:38]

I'm not sure about this. The original intent was to avoid the DCHECK from
degrade performance in non-official release builds. As now we disable DCHECK by
default for release builds, would the scenarios opting in DCHECK want such
DCHECKs in release build?

[Nico, 2014/03/07 22:58:35]

I think so.

[Xianzhu, 2014/03/07 23:29:36]

Removed the check.

     DCHECK_LT(offset, internal::kUtf8ValidatorTablesSize);
   return internal::kUtf8ValidatorTables[offset];