Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only

base/i18n/streaming_utf8_validator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This implementation doesn't use ICU. The ICU macros are oriented towards
 // character-at-a-time processing, whereas byte-at-a-time processing is easier
 // with streaming input.
 
 #include "base/i18n/streaming_utf8_validator.h"
 
 #include "base/i18n/utf8_validator_tables.h"
 #include "base/logging.h"
 
 namespace base {
 namespace {
 
 uint8 StateTableLookup(uint8 offset) {
-  // Skip the bounds check on non-debug builds so that it isn't necessary to set
-  // LOGGING_IS_OFFICIAL_BUILD just to do a performance test.
+  // Skip the bounds check on non-debug builds.
   if (logging::DEBUG_MODE)

[Xianzhu, 2014/03/07 22:40:38]

I'm not sure about this. The original intent was to avoid the DCHECK from
degrade performance in non-official release builds. As now we disable DCHECK by
default for release builds, would the scenarios opting in DCHECK want such
DCHECKs in release build?

[Nico, 2014/03/07 22:58:35]

I think so.

[Xianzhu, 2014/03/07 23:29:36]

Removed the check.

     DCHECK_LT(offset, internal::kUtf8ValidatorTablesSize);
   return internal::kUtf8ValidatorTables[offset];
 }
 
 }  // namespace
 
 StreamingUtf8Validator::State StreamingUtf8Validator::AddBytes(const char* data,
                                                                size_t size) {
   // Copy |state_| into a local variable so that the compiler doesn't have to be
   // careful of aliasing.
@@ skipping 22 matching lines @@
 void StreamingUtf8Validator::Reset() {
   state_ = 0u;
 }
 
 bool StreamingUtf8Validator::Validate(const std::string& string) {
   return StreamingUtf8Validator().AddBytes(string.data(), string.size()) ==
          VALID_ENDPOINT;
 }
 
 }  // namespace base