Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1895863002: Gerrit git cl: temporary disable cc option on upload. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl: temporary disable cc option on upload. Gerrit doesn't allow arbitrary non-member emails for now, thus removign this feature until either Gerrit allows it, or we have a per-repo opt-in way. TBR=andybons@chromium.org BUG=604377 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M git_cl.py View 1 chunk +4 lines, -1 line 0 comments Download
M tests/git_cl_test.py View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-18 16:13:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895863002/1
4 years, 8 months ago (2016-04-18 16:13:17 UTC) #3
Sergiy Byelozyorov
lgtm
4 years, 8 months ago (2016-04-18 16:14:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 16:16:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895863002/1
4 years, 8 months ago (2016-04-18 16:16:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299988
4 years, 8 months ago (2016-04-18 16:19:05 UTC) #11
tandrii(chromium)
4 years, 6 months ago (2016-06-03 16:54:38 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2034143002/ by tandrii@chromium.org.

The reason for reverting is: We've whitelisted cc-ed emails in Gerrit, and so
let's try setting cc= again..

Powered by Google App Engine
This is Rietveld 408576698