Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: tests/git_cl_test.py

Issue 1895863002: Gerrit git cl: temporary disable cc option on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index a78c7383c5dc992a6906de3cbae6d36d50dbd4ad..8b00ac7e15647f8ff5a5f9aabf9cde1699feb363 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -809,13 +809,17 @@ class TestGitCl(TestCase):
((['git', 'config', 'rietveld.cc'],), '')
]
# Add cc from watch list.
- if ref_suffix == '':
- ref_suffix = '%cc=joe@example.com'
- else:
- ref_suffix += ',cc=joe@example.com'
+ # TODO(tandrii): bring this back after http://crbug.com/604377.
+ # if ref_suffix == '':
+ # ref_suffix = '%cc=joe@example.com'
+ # else:
+ # ref_suffix += ',cc=joe@example.com'
if reviewers:
- ref_suffix += ',' + ','.join('r=%s' % email
- for email in sorted(reviewers))
+ if ref_suffix:
+ ref_suffix += ','
+ else:
+ ref_suffix = '%'
+ ref_suffix += ','.join('r=%s' % email for email in sorted(reviewers))
calls += [
((['git', 'push', 'origin',
ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698