Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1895743007: Disable aura window capture unit tests in unix (Closed)

Created:
4 years, 8 months ago by GeorgeZ
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, glider+watch_chromium.org, mcasas+watch+vc_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable aura window capture unit tests in unix as a work around. BUG=602494, 603823 Committed: https://crrev.com/230518ed8b883f180bc87e42f30a621cd2125301 Cr-Commit-Position: refs/heads/master@{#388797}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/media/native_desktop_media_list_unittest.cc View 1 2 6 chunks +12 lines, -6 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
GeorgeZ
Sergey, Would you please take a look of this CL? Thanks
4 years, 8 months ago (2016-04-20 20:12:07 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native_desktop_media_list_unittest.cc File chrome/browser/media/native_desktop_media_list_unittest.cc (right): https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native_desktop_media_list_unittest.cc#newcode37 chrome/browser/media/native_desktop_media_list_unittest.cc:37: #if defined(OS_WIN) it should be clear from the code ...
4 years, 8 months ago (2016-04-20 20:58:14 UTC) #5
GeorgeZ
Sergey, I have updated based on your comments. Thanks, https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native_desktop_media_list_unittest.cc File chrome/browser/media/native_desktop_media_list_unittest.cc (right): https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native_desktop_media_list_unittest.cc#newcode37 chrome/browser/media/native_desktop_media_list_unittest.cc:37: ...
4 years, 8 months ago (2016-04-20 21:38:33 UTC) #6
Sergey Ulanov
lgtm https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/native_desktop_media_list_unittest.cc File chrome/browser/media/native_desktop_media_list_unittest.cc (right): https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/native_desktop_media_list_unittest.cc#newcode36 chrome/browser/media/native_desktop_media_list_unittest.cc:36: // Aura window capture unit tests are not ...
4 years, 8 months ago (2016-04-20 21:44:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895743007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895743007/40001
4 years, 8 months ago (2016-04-21 17:05:13 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 17:09:44 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/230518ed8b883f180bc87e42f30a621cd2125301 Cr-Commit-Position: refs/heads/master@{#388797}
4 years, 8 months ago (2016-04-22 19:35:35 UTC) #14
GeorgeZ
4 years, 8 months ago (2016-04-23 17:56:12 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/na...
File chrome/browser/media/native_desktop_media_list_unittest.cc (right):

https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/na...
chrome/browser/media/native_desktop_media_list_unittest.cc:36: // Aura window
capture unit tests are not stable in unix OS. crbug.com/602494
On 2016/04/20 21:44:24, Sergey Ulanov wrote:
> s/unix OS/linux/

Done.

Powered by Google App Engine
This is Rietveld 408576698