Disable aura window capture unit tests in unix

Disable aura window capture unit tests in unix as a work around.

BUG=602494, 603823
Committed: https://crrev.com/230518ed8b883f180bc87e42f30a621cd2125301
Cr-Commit-Position: refs/heads/master@{#388797}

[GeorgeZ, 2016-04-18 21:04:30]

Description was changed from

==========
Disable aura window capture unit tests in unix

BUG=602494, 60382
==========

to

==========
Disable aura window capture unit tests in unix

BUG=602494, 603823
==========

[GeorgeZ, 2016-04-20 20:11:06]

Description was changed from

==========
Disable aura window capture unit tests in unix

BUG=602494, 603823
==========

to

==========
Disable aura window capture unit tests in unix as a work around.

BUG=602494, 603823
==========

[GeorgeZ, 2016-04-20 20:11:06]

gyzhou@chromium.org changed reviewers:
+ sergeyu@chromium.org

[GeorgeZ, 2016-04-20 20:12:07]

Sergey,

Would you please take a look of this CL?

Thanks

[Sergey Ulanov, 2016-04-20 20:58:14]

https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native...
File chrome/browser/media/native_desktop_media_list_unittest.cc (right):

https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native...
chrome/browser/media/native_desktop_media_list_unittest.cc:37: #if
defined(OS_WIN)
it should be clear from the code why Aura tests are enabled only Windows.

Suggest ENABLE_AURA_TESTS flag and use it below, i.e.:

#if defined(OS_WIN)
#define ENABLE_AURA_TESTS
#endif

Also add a comment with a reference to the tracking bug

https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native...
chrome/browser/media/native_desktop_media_list_unittest.cc:189:
model_->SetUpdatePeriod(base::TimeDelta::FromMilliseconds(20));
Why change this period?

[GeorgeZ, 2016-04-20 21:38:33]

Sergey,

I have updated based on your comments.

Thanks,

https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native...
File chrome/browser/media/native_desktop_media_list_unittest.cc (right):

https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native...
chrome/browser/media/native_desktop_media_list_unittest.cc:37: #if
defined(OS_WIN)
On 2016/04/20 20:58:14, Sergey Ulanov wrote:
> it should be clear from the code why Aura tests are enabled only Windows.
> 
> Suggest ENABLE_AURA_TESTS flag and use it below, i.e.:
> 
> #if defined(OS_WIN)
> #define ENABLE_AURA_TESTS
> #endif
> 
> Also add a comment with a reference to the tracking bug

Good point.

https://codereview.chromium.org/1895743007/diff/1/chrome/browser/media/native...
chrome/browser/media/native_desktop_media_list_unittest.cc:189:
model_->SetUpdatePeriod(base::TimeDelta::FromMilliseconds(20));
On 2016/04/20 20:58:14, Sergey Ulanov wrote:
> Why change this period?

Pleas see Comment 3 in
https://bugs.chromium.org/p/chromium/issues/detail?id=602494

In short, the message loop may not always quit after one refresh(). Add a little
delay will help message loop to have more chance to quit after one refresh() or
smaller number of refresh().

[Sergey Ulanov, 2016-04-20 21:44:24]

lgtm

https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/na...
File chrome/browser/media/native_desktop_media_list_unittest.cc (right):

https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/na...
chrome/browser/media/native_desktop_media_list_unittest.cc:36: // Aura window
capture unit tests are not stable in unix OS. crbug.com/602494
s/unix OS/linux/

[GeorgeZ, 2016-04-21 17:04:46]

The CQ bit was checked by gyzhou@chromium.org

[GeorgeZ, 2016-04-21 17:04:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1895743007/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-21 17:05:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895743007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895743007/40001

[commit-bot: I haz the power, 2016-04-21 17:09:43]

Description was changed from

==========
Disable aura window capture unit tests in unix as a work around.

BUG=602494, 603823
==========

to

==========
Disable aura window capture unit tests in unix as a work around.

BUG=602494, 603823
==========

[commit-bot: I haz the power, 2016-04-21 17:09:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:35:34]

Description was changed from

==========
Disable aura window capture unit tests in unix as a work around.

BUG=602494, 603823
==========

to

==========
Disable aura window capture unit tests in unix as a work around.

BUG=602494, 603823

Committed: https://crrev.com/230518ed8b883f180bc87e42f30a621cd2125301
Cr-Commit-Position: refs/heads/master@{#388797}
==========

[commit-bot: I haz the power, 2016-04-22 19:35:35]

Patchset 3 (id:??) landed as
https://crrev.com/230518ed8b883f180bc87e42f30a621cd2125301
Cr-Commit-Position: refs/heads/master@{#388797}

[GeorgeZ, 2016-04-23 17:56:12]

https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/na...
File chrome/browser/media/native_desktop_media_list_unittest.cc (right):

https://codereview.chromium.org/1895743007/diff/20001/chrome/browser/media/na...
chrome/browser/media/native_desktop_media_list_unittest.cc:36: // Aura window
capture unit tests are not stable in unix OS. crbug.com/602494
On 2016/04/20 21:44:24, Sergey Ulanov wrote:
> s/unix OS/linux/

Done.