Disable aura window capture unit tests in unix

chrome/browser/media/native_desktop_media_list_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/native_desktop_media_list.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
 #include <vector>
@@ skipping 16 matching lines @@
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 #include "ui/views/widget/widget.h"
 
 using content::DesktopMediaID;
 using testing::_;
 using testing::DoAll;
 
 namespace {
 
 static const int kDefaultWindowCount = 2;
-#if defined(USE_AURA)
+#if defined(OS_WIN)

[Sergey Ulanov, 2016/04/20 20:58:14]

it should be clear from the code why Aura tests are enabled only Windows.

Suggest ENABLE_AURA_TESTS flag and use it below, i.e.:

#if defined(OS_WIN)
#define ENABLE_AURA_TESTS
#endif

Also add a comment with a reference to the tracking bug

[GeorgeZ, 2016/04/20 21:38:33]

Good point.

 static const int kDefaultAuraCount = 1;
 #else
 static const int kDefaultAuraCount = 0;
 #endif
 
 class MockObserver : public DesktopMediaListObserver {
  public:
   MOCK_METHOD2(OnSourceAdded, void(DesktopMediaList* list, int index));
   MOCK_METHOD2(OnSourceRemoved, void(DesktopMediaList* list, int index));
   MOCK_METHOD3(OnSourceMoved,
@@ skipping 131 matching lines @@
     if (window)
       window_capturer_ = new FakeWindowCapturer();
     else
       window_capturer_ = nullptr;
 
     model_.reset(new NativeDesktopMediaList(
         std::unique_ptr<webrtc::ScreenCapturer>(screen_capturer),
         std::unique_ptr<webrtc::WindowCapturer>(window_capturer_)));
 
     // Set update period to reduce the time it takes to run tests.
-    model_->SetUpdatePeriod(base::TimeDelta::FromMilliseconds(5));
+    model_->SetUpdatePeriod(base::TimeDelta::FromMilliseconds(20));

[Sergey Ulanov, 2016/04/20 20:58:14]

Why change this period?

[GeorgeZ, 2016/04/20 21:38:33]

Pleas see Comment 3 in
https://bugs.chromium.org/p/chromium/issues/detail?id=602494

In short, the message loop may not always quit after one refresh(). Add a little
delay will help message loop to have more chance to quit after one refresh() or
smaller number of refresh().

   }
 
   void AddNativeWindow(int id) {
     webrtc::WindowCapturer::Window window;
     window.id = id;
     window.title = "Test window";
     window_list_.push_back(window);
   }
 
 #if defined(USE_AURA)
@@ skipping 181 matching lines @@
   webrtc::WindowCapturer::Window window;
   AddNativeWindow(index);
   window_capturer_->SetWindowList(window_list_);
 
   message_loop()->Run();
 
   EXPECT_EQ(model_->GetSource(index).id.type, DesktopMediaID::TYPE_WINDOW);
   EXPECT_EQ(model_->GetSource(index).id.id, index);
 }
 
-#if defined(USE_AURA)
+#if defined(OS_WIN)
 TEST_F(NativeDesktopMediaListTest, AddAuraWindow) {
   AddWindowsAndVerify(true, kDefaultWindowCount, kDefaultAuraCount, false);
 
   const int index = kDefaultWindowCount + 1;
   EXPECT_CALL(observer_, OnSourceAdded(model_.get(), index))
       .WillOnce(DoAll(CheckListSize(model_.get(), index + 1),
                       QuitMessageLoop(message_loop())));
 
   AddAuraWindow();
   window_capturer_->SetWindowList(window_list_);
 
   message_loop()->Run();
 
   int native_id = window_list_.back().id;
   EXPECT_EQ(model_->GetSource(index).id.type, DesktopMediaID::TYPE_WINDOW);
   EXPECT_EQ(model_->GetSource(index).id.id, native_id);
   EXPECT_EQ(model_->GetSource(index).id.aura_id,
             native_aura_id_map_[native_id]);
 }
-#endif  // defined(USE_AURA)
+#endif  // defined(OS_WIN)
 
 TEST_F(NativeDesktopMediaListTest, RemoveNativeWindow) {
   AddWindowsAndVerify(true, kDefaultWindowCount, kDefaultAuraCount, false);
 
   EXPECT_CALL(observer_, OnSourceRemoved(model_.get(), 1))
       .WillOnce(DoAll(CheckListSize(model_.get(), kDefaultWindowCount),
                       QuitMessageLoop(message_loop())));
 
   window_list_.erase(window_list_.begin());
   window_capturer_->SetWindowList(window_list_);
 
   message_loop()->Run();
 }
 
-#if defined(USE_AURA)
+#if defined(OS_WIN)
 TEST_F(NativeDesktopMediaListTest, RemoveAuraWindow) {
   AddWindowsAndVerify(true, kDefaultWindowCount, kDefaultAuraCount, false);
 
   int aura_window_start_index = kDefaultWindowCount - kDefaultAuraCount + 1;
   EXPECT_CALL(observer_, OnSourceRemoved(model_.get(), aura_window_start_index))
       .WillOnce(DoAll(CheckListSize(model_.get(), kDefaultWindowCount),
                       QuitMessageLoop(message_loop())));
 
   RemoveAuraWindow(0);
   window_capturer_->SetWindowList(window_list_);
 
   message_loop()->Run();
 }
-#endif  // defined(USE_AURA)
+#endif  // defined(OS_WIN)
 
 TEST_F(NativeDesktopMediaListTest, RemoveAllWindows) {
   AddWindowsAndVerify(true, kDefaultWindowCount, kDefaultAuraCount, false);
 
   testing::InSequence seq;
   for (int i = 0; i < kDefaultWindowCount - 1; i++) {
     EXPECT_CALL(observer_, OnSourceRemoved(model_.get(), 1))
         .WillOnce(CheckListSize(model_.get(), kDefaultWindowCount - i));
   }
   EXPECT_CALL(observer_, OnSourceRemoved(model_.get(), 1))
@@ skipping 41 matching lines @@
                       QuitMessageLoop(message_loop())));
 
   // Swap the two windows.
   webrtc::WindowCapturer::Window temp = window_list_[0];
   window_list_[0] = window_list_[1];
   window_list_[1] = temp;
   window_capturer_->SetWindowList(window_list_);
 
   message_loop()->Run();
 }