Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1895743002: Revert of Safe Browsing: CheckApiBlacklist request implementation (Closed)

Created:
4 years, 8 months ago by kcarattini
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, vakh (use Gerrit instead)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Safe Browsing: CheckApiBlacklist request implementation (patchset #11 id:200001 of https://codereview.chromium.org/1843383002/ ) Reason for revert: Causing memory failures: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/37789/steps/memory%20test%3A%20components/logs/stdio Original issue's description: > Safe Browsing: CheckApiBlacklist request implementation > > BUG=561867 > > Committed: https://crrev.com/1343c9206db66bc5ec0a8aa67d745813b197cde4 > Cr-Commit-Position: refs/heads/master@{#387869} TBR=nparker@chromium.org,sky@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561867 Committed: https://crrev.com/392aad671fe5f3bba1aa39e7936607f04b6eb682 Cr-Commit-Position: refs/heads/master@{#387886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -237 lines) Patch
M components/components_tests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M components/safe_browsing_db/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/database_manager.h View 4 chunks +5 lines, -39 lines 0 comments Download
M components/safe_browsing_db/database_manager.cc View 2 chunks +7 lines, -55 lines 0 comments Download
D components/safe_browsing_db/database_manager_unittest.cc View 1 chunk +0 lines, -134 lines 0 comments Download
M components/safe_browsing_db/test_database_manager.h View 2 chunks +6 lines, -2 lines 0 comments Download
M components/safe_browsing_db/test_database_manager.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kcarattini
Created Revert of Safe Browsing: CheckApiBlacklist request implementation
4 years, 8 months ago (2016-04-18 11:00:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895743002/1
4 years, 8 months ago (2016-04-18 11:00:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895743002/1
4 years, 8 months ago (2016-04-18 11:01:29 UTC) #3
commit-bot: I haz the power
Failed to apply patch for components/components_tests.gyp: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-04-18 11:01:43 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 11:02:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/392aad671fe5f3bba1aa39e7936607f04b6eb682
Cr-Commit-Position: refs/heads/master@{#387886}

Powered by Google App Engine
This is Rietveld 408576698