Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: components/safe_browsing_db/database_manager.h

Issue 1895743002: Revert of Safe Browsing: CheckApiBlacklist request implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db/DEPS ('k') | components/safe_browsing_db/database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/database_manager.h
diff --git a/components/safe_browsing_db/database_manager.h b/components/safe_browsing_db/database_manager.h
index a1fa63dda02a7867ba080d1b9a0f3be38cc76356..5fa427ff29e086d420d0277507eeaf69d03a537a 100644
--- a/components/safe_browsing_db/database_manager.h
+++ b/components/safe_browsing_db/database_manager.h
@@ -14,8 +14,6 @@
#include <string>
#include <vector>
-#include "base/gtest_prod_util.h"
-#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "components/safe_browsing_db/hit_report.h"
#include "components/safe_browsing_db/util.h"
@@ -64,6 +62,7 @@
SBThreatType threat_type,
const std::string& threat_hash) {}
};
+
// Returns true if URL-checking is supported on this build+device.
// If false, calls to CheckBrowseUrl may dcheck-fail.
@@ -149,20 +148,15 @@
virtual bool IsCsdWhitelistKillSwitchOn() = 0;
// Called on the IO thread to cancel a pending check if the result is no
- // longer needed. Also called after the result has been handled. Api checks
- // are handled separately. To cancel an API check use CancelApiCheck.
+ // longer needed. Also called after the result has been handled.
virtual void CancelCheck(Client* client) = 0;
-
- // TODO(kcarattini): Add a CancelApiCheck method.
// Called on the IO thread to check if the given url has blacklisted APIs.
// "client" is called asynchronously with the result when it is ready.
// This method has the same implementation for both the local and remote
// database managers since it pings Safe Browsing servers directly without
- // accessing the database at all. Returns true if we can synchronously
- // determine that the url is safe. Otherwise it returns false, and "client" is
- // called asynchronously with the result when it is ready.
- virtual bool CheckApiBlacklistUrl(const GURL& url, Client* client);
+ // accessing the database at all.
+ virtual void CheckApiBlacklistUrl(const GURL& url, Client* client);
// Called to initialize objects that are used on the io_thread, such as the
// v4 protocol manager. This may be called multiple times during the life of
@@ -181,35 +175,7 @@
friend class base::RefCountedThreadSafe<SafeBrowsingDatabaseManager>;
- FRIEND_TEST_ALL_PREFIXES(SafeBrowsingDatabaseManagerTest,
- CheckApiBlacklistUrlPrefixes);
-
- // Bundled client info for an API abuse hash prefix check.
- class SafeBrowsingApiCheck {
- public:
- SafeBrowsingApiCheck(const GURL& url,
- const std::vector<SBFullHash>& full_hashes,
- Client* client);
- ~SafeBrowsingApiCheck();
-
- private:
- GURL url_;
- std::vector<SBFullHash> full_hashes_;
- // Not owned.
- SafeBrowsingDatabaseManager::Client* client_;
-
- DISALLOW_COPY_AND_ASSIGN(SafeBrowsingApiCheck);
- };
-
- // Called on the IO thread wheh the SafeBrowsingProtocolManager has received
- // the full hash and api results for prefixes of the |url| argument in
- // CheckApiBlacklistUrl.
- virtual void HandleGetHashesWithApisResults(
- std::shared_ptr<SafeBrowsingApiCheck> check,
- const std::vector<SBFullHashResult>& full_hash_results,
- const base::TimeDelta& negative_cache_duration);
-
- // Created and destroyed via StartOnIOThread/StopOnIOThread.
+ // Created and destroyed via StartonIOThread/StopOnIOThread.
V4GetHashProtocolManager* v4_get_hash_protocol_manager_;
}; // class SafeBrowsingDatabaseManager
« no previous file with comments | « components/safe_browsing_db/DEPS ('k') | components/safe_browsing_db/database_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698