Convert HTMLFrameOwnerElement and FocusController to use Frame.

Source/core/editing/Editor.cpp

Index: Source/core/editing/Editor.cpp
diff --git a/Source/core/editing/Editor.cpp b/Source/core/editing/Editor.cpp
index ba4484d2aac3492583c216773431702b3b8b7d96..c08d976fd6e73036306ca1be4443f185cc9daf3e 100644
--- a/Source/core/editing/Editor.cpp
+++ b/Source/core/editing/Editor.cpp
@@ -807,7 +807,7 @@ bool Editor::insertTextWithoutSendingTextEvent(const String& text, bool selectIn
             // Reveal the current selection
             if (LocalFrame* editedFrame = document->frame()) {
                 if (Page* page = editedFrame->page())
-                    page->focusController().focusedOrMainFrame()->selection().revealSelection(ScrollAlignment::alignCenterIfNeeded);
+                    toLocalFrame(page->focusController().focusedOrMainFrame())->selection().revealSelection(ScrollAlignment::alignCenterIfNeeded);

[dcheng, 2014/03/17 18:17:44]

Is this always guaranteed to be a local frame? That doesn't seem like it would
always be the case.

[kenrb, 2014/03/18 20:01:19]

I was thinking a selected frame would have to be local in order to be editing
it, but I'm not sure about that so I've added the check for the sake of caution.

[dcheng, 2014/03/19 20:50:03]

Thinking about this more, I'm not 100% sure what the behavior should be here,
since I'm not familiar with this part of the editing code. I don't think the
editing action itself can take place in a remote frame. And it looks like the
intent of this code is to scroll the changed selection into view... so it's not
clear to me why it falls back to focusedOrMainFrame() to do this (since
presumably the selection you're editing should be local to this frame...)

Maybe let's leave off the if() and see what explodes =)

[kenrb, 2014/03/20 15:56:57]

Ok. If this is wrong, we should see ASSERTs after we start testing editing with
RemoteFrames present.

             }
         }
     }