Convert HTMLFrameOwnerElement and FocusController to use Frame.

Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 789 matching lines @@
 
             // Insert the text
             TypingCommand::Options options = 0;
             if (selectInsertedText)
                 options |= TypingCommand::SelectInsertedText;
             TypingCommand::insertText(*document.get(), text, selection, options, triggeringEvent && triggeringEvent->isComposition() ? TypingCommand::TextCompositionConfirm : TypingCommand::TextCompositionNone);
 
             // Reveal the current selection
             if (LocalFrame* editedFrame = document->frame()) {
                 if (Page* page = editedFrame->page())
-                    page->focusController().focusedOrMainFrame()->selection().revealSelection(ScrollAlignment::alignCenterIfNeeded);
+                    toLocalFrame(page->focusController().focusedOrMainFrame())->selection().revealSelection(ScrollAlignment::alignCenterIfNeeded);

[dcheng, 2014/03/17 18:17:44]

Is this always guaranteed to be a local frame? That doesn't seem like it would
always be the case.

[kenrb, 2014/03/18 20:01:19]

I was thinking a selected frame would have to be local in order to be editing
it, but I'm not sure about that so I've added the check for the sake of caution.

[dcheng, 2014/03/19 20:50:03]

Thinking about this more, I'm not 100% sure what the behavior should be here,
since I'm not familiar with this part of the editing code. I don't think the
editing action itself can take place in a remote frame. And it looks like the
intent of this code is to scroll the changed selection into view... so it's not
clear to me why it falls back to focusedOrMainFrame() to do this (since
presumably the selection you're editing should be local to this frame...)

Maybe let's leave off the if() and see what explodes =)

[kenrb, 2014/03/20 15:56:57]

Ok. If this is wrong, we should see ASSERTs after we start testing editing with
RemoteFrames present.

             }
         }
     }
 
     return true;
 }
 
 bool Editor::insertLineBreak()
 {
     if (!canEdit())
@@ skipping 410 matching lines @@
     return m_frame.spellChecker();
 }
 
 void Editor::toggleOverwriteModeEnabled()
 {
     m_overwriteModeEnabled = !m_overwriteModeEnabled;
     frame().selection().setShouldShowBlockCursor(m_overwriteModeEnabled);
 }
 
 } // namespace WebCore