Source/web/WebPageSerializer.cpp - Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPageSerializer.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve FocusController handling of RemoteFrames Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPageSerializer.cpp

diff --git a/Source/web/WebPageSerializer.cpp b/Source/web/WebPageSerializer.cpp

index ac543d6b2c368cefdac827f7c9f1d0be2be9777d..8640a29b45ceedc24edd50bded8cef4ad32ef47f 100644

--- a/Source/web/WebPageSerializer.cpp

+++ b/Source/web/WebPageSerializer.cpp

@@ -113,7 +113,7 @@ void retrieveResourcesForElement(Element* element,

if ((element->hasTagName(HTMLNames::iframeTag) || element->hasTagName(HTMLNames::frameTag)

|| element->hasTagName(HTMLNames::objectTag) || element->hasTagName(HTMLNames::embedTag))

&& element->isFrameOwnerElement()) {

- if (LocalFrame* frame = toHTMLFrameOwnerElement(element)->contentFrame()) {

+ if (LocalFrame* frame = toLocalFrame(toHTMLFrameOwnerElement(element)->contentFrame())) {

if (!visitedFrames->contains(frame))

framesToVisit->append(frame);

return;

« Source/bindings/v8/V8WindowShell.cpp ('K') | « Source/web/WebFrameImpl.cpp ('k') | Source/web/WebViewImpl.h » ('j') | no next file with comments »