third_party/WebKit/Source/core/layout/LayoutTheme.cpp - Issue 1895723002: input[type=range]: box-shadow should not make -webkit-appearance none.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 1895723002: input[type=range]: box-shadow should not make -webkit-appearance none. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/platform/mac/fast/forms/range/range-appearance-basic-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

index 80427aca4046736eebf16fe4cb4e32b72c3e3a02..e5320a00c95703d1c365dc36fdb15d0e9c1186dd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

@@ -406,10 +406,6 @@ bool LayoutTheme::isControlStyled(const ComputedStyle& style) const

case TextFieldPart:

return style.hasAuthorBackground() || style.hasAuthorBorder() || style.boxShadow();

- case SliderHorizontalPart:

- case SliderVerticalPart:

- return style.boxShadow();

default:

return false;

}