Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 1895723002: input[type=range]: box-shadow should not make -webkit-appearance none. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * This file is part of the theme implementation for form controls in WebCore. 2 * This file is part of the theme implementation for form controls in WebCore.
3 * 3 *
4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc. 4 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Computer, Inc.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 case ProgressBarPart: 399 case ProgressBarPart:
400 case MeterPart: 400 case MeterPart:
401 return style.hasAuthorBackground() || style.hasAuthorBorder(); 401 return style.hasAuthorBackground() || style.hasAuthorBorder();
402 402
403 case MenulistPart: 403 case MenulistPart:
404 case SearchFieldPart: 404 case SearchFieldPart:
405 case TextAreaPart: 405 case TextAreaPart:
406 case TextFieldPart: 406 case TextFieldPart:
407 return style.hasAuthorBackground() || style.hasAuthorBorder() || style.b oxShadow(); 407 return style.hasAuthorBackground() || style.hasAuthorBorder() || style.b oxShadow();
408 408
409 case SliderHorizontalPart:
410 case SliderVerticalPart:
411 return style.boxShadow();
412
413 default: 409 default:
414 return false; 410 return false;
415 } 411 }
416 } 412 }
417 413
418 void LayoutTheme::addVisualOverflow(const LayoutObject& object, IntRect& borderB ox) 414 void LayoutTheme::addVisualOverflow(const LayoutObject& object, IntRect& borderB ox)
419 { 415 {
420 if (m_platformTheme) 416 if (m_platformTheme)
421 m_platformTheme->addVisualOverflow(object.style()->appearance(), control StatesForLayoutObject(object), object.style()->effectiveZoom(), borderBox); 417 m_platformTheme->addVisualOverflow(object.style()->appearance(), control StatesForLayoutObject(object), object.style()->effectiveZoom(), borderBox);
422 } 418 }
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 919
924 // padding - not honored by WinIE, needs to be removed. 920 // padding - not honored by WinIE, needs to be removed.
925 style.resetPadding(); 921 style.resetPadding();
926 922
927 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme) 923 // border - honored by WinIE, but looks terrible (just paints in the control box and turns off the Windows XP theme)
928 // for now, we will not honor it. 924 // for now, we will not honor it.
929 style.resetBorder(); 925 style.resetBorder();
930 } 926 }
931 927
932 } // namespace blink 928 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698