Remove unused histograms: Net.QuicSession.ConnectSelectPort*

Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636
Committed: https://crrev.com/b35b415ca35f37b2c773e20f26c7a9f27ec10ada
Cr-Commit-Position: refs/heads/master@{#389870}

[Zhongyi Shi, 2016-04-15 23:52:00]

Description was changed from

==========
Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636
==========

to

==========
Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636
==========

[Zhongyi Shi, 2016-04-15 23:52:01]

zhongyi@chromium.org changed reviewers:
+ asvitkine@chromium.org, rch@chromium.org

[Ryan Hamilton, 2016-04-18 19:04:02]

lgtm

[Alexei Svitkine (slow), 2016-04-21 15:10:34]

https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:91514: -  <affected-histogram
name="Net.QuicSession.ConnectSelectPort"/>
Mark the affected histogram as <obsolete> instead.

[Zhongyi Shi, 2016-04-25 22:55:21]

On 2016/04/21 15:10:34, Alexei Svitkine wrote:
>
https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:91514: -  <affected-histogram
> name="Net.QuicSession.ConnectSelectPort"/>
> Mark the affected histogram as <obsolete> instead.

Sorry for the delayed response, Alexei. I understand that usually we leave the
<affected-histogram> as is to decode data from older versions but mark the
<histogram> as <obsolete>. However, it seems like the old code doesn't have the
<histogram> Net.QuicSession.ConnectSelectPort </histogram>. It might be deleted
by an old commit already? Should we leave the <affected-histogram> as it is?

[Alexei Svitkine (slow), 2016-04-26 15:17:30]

On 2016/04/25 22:55:21, Zhongyi Shi wrote:
> On 2016/04/21 15:10:34, Alexei Svitkine wrote:
> >
>
https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
> > File tools/metrics/histograms/histograms.xml (left):
> > 
> >
>
https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
> > tools/metrics/histograms/histograms.xml:91514: -  <affected-histogram
> > name="Net.QuicSession.ConnectSelectPort"/>
> > Mark the affected histogram as <obsolete> instead.
> 
> Sorry for the delayed response, Alexei. I understand that usually we leave the
> <affected-histogram> as is to decode data from older versions but mark the
> <histogram> as <obsolete>. However, it seems like the old code doesn't have
the
> <histogram> Net.QuicSession.ConnectSelectPort </histogram>. It might be
deleted
> by an old commit already? Should we leave the <affected-histogram> as it is?

So, Net.QuicSession.ConnectSelectPort is actually the "SelectPort" suffix
applied to Net.QuicSession.Connect - for which there is an entry. So it's still
in the XML.

My suggestion is to add <obsolete> tag to the line you're removing, i.e.:

<affected-histogram
name="Net.QuicSession.ConnectSelectPort"><obsolete>...</obsolete></affected-histogram>

[Zhongyi Shi, 2016-04-26 18:54:46]

On 2016/04/26 15:17:30, Alexei Svitkine wrote:
> On 2016/04/25 22:55:21, Zhongyi Shi wrote:
> > On 2016/04/21 15:10:34, Alexei Svitkine wrote:
> > >
> >
>
https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
> > > File tools/metrics/histograms/histograms.xml (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/1895533004/diff/1/tools/metrics/histograms/hi...
> > > tools/metrics/histograms/histograms.xml:91514: -  <affected-histogram
> > > name="Net.QuicSession.ConnectSelectPort"/>
> > > Mark the affected histogram as <obsolete> instead.
> > 
> > Sorry for the delayed response, Alexei. I understand that usually we leave
the
> > <affected-histogram> as is to decode data from older versions but mark the
> > <histogram> as <obsolete>. However, it seems like the old code doesn't have
> the
> > <histogram> Net.QuicSession.ConnectSelectPort </histogram>. It might be
> deleted
> > by an old commit already? Should we leave the <affected-histogram> as it is?
> 
> So, Net.QuicSession.ConnectSelectPort is actually the "SelectPort" suffix
> applied to Net.QuicSession.Connect - for which there is an entry. So it's
still
> in the XML.
> 
> My suggestion is to add <obsolete> tag to the line you're removing, i.e.:
> 
> <affected-histogram
>
name="Net.QuicSession.ConnectSelectPort"><obsolete>...</obsolete></affected-histogram>

I see, sorry for missing the suffix part. I only did a fullname search. Done
now.

[Alexei Svitkine (slow), 2016-04-26 18:58:01]

lgtm

[Zhongyi Shi, 2016-04-26 19:15:07]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2016-04-26 19:15:08]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1895533004/#ps40001
(title: "mark affected-histogram has obsolete")

[commit-bot: I haz the power, 2016-04-26 19:15:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895533004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895533004/40001

[commit-bot: I haz the power, 2016-04-26 20:16:32]

Description was changed from

==========
Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636
==========

to

==========
Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636
==========

[commit-bot: I haz the power, 2016-04-26 20:16:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-26 20:19:19]

Description was changed from

==========
Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636
==========

to

==========
Remove unused histograms: Net.QuicSession.ConnectSelectPort*

BUG=603636

Committed: https://crrev.com/b35b415ca35f37b2c773e20f26c7a9f27ec10ada
Cr-Commit-Position: refs/heads/master@{#389870}
==========

[commit-bot: I haz the power, 2016-04-26 20:19:20]

Patchset 3 (id:??) landed as
https://crrev.com/b35b415ca35f37b2c773e20f26c7a9f27ec10ada
Cr-Commit-Position: refs/heads/master@{#389870}