Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: net/quic/quic_chromium_client_session.cc

Issue 1895533004: Remove unused histograms: Net.QuicSession.ConnectSelectPort* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@REMOVE_HISTOGRAMS_2
Patch Set: mark affected-histogram has obsolete Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_chromium_client_session.h" 5 #include "net/quic/quic_chromium_client_session.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 315
316 // Don't bother with these histogram during tests, which mock out 316 // Don't bother with these histogram during tests, which mock out
317 // num_sent_client_hellos(). 317 // num_sent_client_hellos().
318 if (round_trip_handshakes < 0 || !stream_factory_) 318 if (round_trip_handshakes < 0 || !stream_factory_)
319 return; 319 return;
320 320
321 bool port_selected = stream_factory_->enable_port_selection(); 321 bool port_selected = stream_factory_->enable_port_selection();
322 SSLInfo ssl_info; 322 SSLInfo ssl_info;
323 // QUIC supports only secure urls. 323 // QUIC supports only secure urls.
324 if (GetSSLInfo(&ssl_info) && ssl_info.cert.get()) { 324 if (GetSSLInfo(&ssl_info) && ssl_info.cert.get()) {
325 if (port_selected) { 325 if (!port_selected) {
326 UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectSelectPortForHTTPS",
327 round_trip_handshakes, 0, 3, 4);
328 } else {
329 UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectRandomPortForHTTPS", 326 UMA_HISTOGRAM_CUSTOM_COUNTS("Net.QuicSession.ConnectRandomPortForHTTPS",
330 round_trip_handshakes, 0, 3, 4); 327 round_trip_handshakes, 0, 3, 4);
331 if (require_confirmation_) { 328 if (require_confirmation_) {
332 UMA_HISTOGRAM_CUSTOM_COUNTS( 329 UMA_HISTOGRAM_CUSTOM_COUNTS(
333 "Net.QuicSession.ConnectRandomPortRequiringConfirmationForHTTPS", 330 "Net.QuicSession.ConnectRandomPortRequiringConfirmationForHTTPS",
334 round_trip_handshakes, 0, 3, 4); 331 round_trip_handshakes, 0, 3, 4);
335 } 332 }
336 } 333 }
337 } 334 }
338 const QuicConnectionStats stats = connection()->GetStats(); 335 const QuicConnectionStats stats = connection()->GetStats();
(...skipping 852 matching lines...) Expand 10 before | Expand all | Expand 10 after
1191 } 1188 }
1192 1189
1193 void QuicChromiumClientSession::DeletePromised( 1190 void QuicChromiumClientSession::DeletePromised(
1194 QuicClientPromisedInfo* promised) { 1191 QuicClientPromisedInfo* promised) {
1195 if (IsOpenStream(promised->id())) 1192 if (IsOpenStream(promised->id()))
1196 streams_pushed_and_claimed_count_++; 1193 streams_pushed_and_claimed_count_++;
1197 QuicClientSessionBase::DeletePromised(promised); 1194 QuicClientSessionBase::DeletePromised(promised);
1198 } 1195 }
1199 1196
1200 } // namespace net 1197 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698