Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895503002: Delete android_amp trybot. (Closed)

Created:
4 years, 8 months ago by bpastene
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6059 lines) Patch
M masters/master.tryserver.chromium.android/builders.pyl View 1 chunk +0 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 2 chunks +4 lines, -2 lines 1 comment Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 2 chunks +0 lines, -11 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/amp_test_failure.json View 1 chunk +0 lines, -3095 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_amp.json View 1 chunk +0 lines, -2939 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bpastene
ptal https://codereview.chromium.org/1895503002/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/1895503002/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode990 scripts/slave/recipe_modules/chromium_tests/steps.py:990: def failures(self, api, suffix): # pragma: no cover ...
4 years, 8 months ago (2016-04-15 16:49:24 UTC) #2
Sergey Berezin
LGTM, and special thanks for planning to remove project-specific code from steps.py!
4 years, 8 months ago (2016-04-15 18:05:25 UTC) #3
ghost stip (do not use)
lgtm, great job!
4 years, 8 months ago (2016-04-15 18:21:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895503002/1
4 years, 8 months ago (2016-04-18 17:13:11 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:17:34 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299992

Powered by Google App Engine
This is Rietveld 408576698