scripts/slave/recipe_modules/chromium_tests/steps.py - Issue 1895503002: Delete android_amp trybot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1895503002: Delete android_amp trybot. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_tests/steps.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py

index 5b5e9a1a0da769c90759cad328719d6974235174..1f3c92f2a29c43ed1b1e4726215049d7820b473a 100644

--- a/scripts/slave/recipe_modules/chromium_tests/steps.py

+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py

@@ -887,6 +887,8 @@ class SwarmingGTestTest(SwarmingTest):

test_results_server='test-results.appspot.com')

+# TODO(bpastene) Remove all AMP recipe code once all use of it has been

+# discontinued. crbug.com/603943

class AMPTest(Test):

AMP_INSTANCE_ADDRESS = '172.22.21.180'

AMP_INSTANCE_PORT = '80'

@@ -982,10 +984,10 @@ class AMPTest(Test):

return valid, failures

- def has_valid_results(self, api, suffix):

+ def has_valid_results(self, api, suffix): # pragma: no cover

return suffix in self._step_results and self._step_results[suffix]['valid']

- def failures(self, api, suffix):

+ def failures(self, api, suffix): # pragma: no cover

bpastene 2016/04/15 16:49:23 Hopefully you can forgive my use of the 'no cover'

assert self.has_valid_results(api, suffix)

return self._step_results[suffix]['failures']