Mark outdated branches on 'cl status'

Mark outdated branches on 'cl status'

'cl status' now compares the uploaded patch against the patch computed
locally. If they differ (ignoring precise line numbers), then the
respective branch is marked 'outdated'.

[Clemens Hammacher, 2016-04-15 14:22:40]

clemensh@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-04-15 15:15:13]

first, thanks for creating CLs.

However, without test, I will not accept this.
Furthermore, it looks to me as you've used Rietveld-specific thing, which
belongs to _RietveldCodereviewImpl class. And if you are adding it, add the the
same for _Gerrit.

With Gerrit, things should actually be much simpler: all you have to do is fetch
the ref with the patch and run "git diff <patch_ref> <local_branch>.

For Rietveld, for the sake of simplicity, maybe do the same? There is also
command to apply Rietveld patch locally, so maybe you can create a new temporary
branch, apply patch on it, and compute the diff?

https://codereview.chromium.org/1895463002/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1895463002/diff/40001/git_cl.py#newcode2930
git_cl.py:2930: information or commit hashes.
nit: add empty line.

[Clemens Hammacher, 2016-04-15 15:19:26]

On 2016/04/15 at 15:15:13, tandrii wrote:
> first, thanks for creating CLs.
> 
> However, without test, I will not accept this.
> Furthermore, it looks to me as you've used Rietveld-specific thing, which
belongs to _RietveldCodereviewImpl class. And if you are adding it, add the the
same for _Gerrit.
> 
> With Gerrit, things should actually be much simpler: all you have to do is
fetch the ref with the patch and run "git diff <patch_ref> <local_branch>.
> 
> For Rietveld, for the sake of simplicity, maybe do the same? There is also
command to apply Rietveld patch locally, so maybe you can create a new temporary
branch, apply patch on it, and compute the diff?
> 
> https://codereview.chromium.org/1895463002/diff/40001/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/1895463002/diff/40001/git_cl.py#newcode2930
> git_cl.py:2930: information or commit hashes.
> nit: add empty line.

I don't know enough about Gerrit to implement this. If you think that that's
necessary, you will have to implement it.
Sorry, I can't put more effort into that.

[Clemens Hammacher, 2016-04-22 09:57:39]

Description was changed from

==========
Mark outdated branches on 'cl status'

'cl status' now compares the uploaded patch against the patch computed
locally. If they differ (ignoring precise line numbers), then the
respective branch is marked 'outdated'.

BUG=
==========

to

==========
Mark outdated branches on 'cl status'

'cl status' now compares the uploaded patch against the patch computed
locally. If they differ (ignoring precise line numbers), then the
respective branch is marked 'outdated'.
==========

[clemensh, 2016-05-06 12:25:01]

Description was changed from

==========
Mark outdated branches on 'cl status'

'cl status' now compares the uploaded patch against the patch computed
locally. If they differ (ignoring precise line numbers), then the
respective branch is marked 'outdated'.
==========

to

==========
Mark outdated branches on 'cl status'

'cl status' now compares the uploaded patch against the patch computed
locally. If they differ (ignoring precise line numbers), then the
respective branch is marked 'outdated'.
==========