Support getting changes of non-HEAD branches

Support getting changes of non-HEAD branches

This requires passing the ref name to several places.

[Clemens Hammacher, 2016-04-15 14:22:33]

clemensh@chromium.org changed reviewers:
+ tandrii@chromium.org

[Clemens Hammacher, 2016-04-15 14:22:34]

This only prepares the actual change: https://codereview.chromium.org/1895463002

[tandrii(chromium), 2016-04-15 15:19:24]

see my comment on the CL that depends on this one. Maybe that other CL can be
written without these changes? I'm not 100% sure, but if so, i'd rather not
touch this code, as we'd spend days reverting, fixing, and relanding this,
because our test coverage is super sparse :(

[Clemens Hammacher, 2016-04-15 15:28:55]

On 2016/04/15 at 15:19:24, tandrii wrote:
> see my comment on the CL that depends on this one. Maybe that other CL can be
written without these changes? I'm not 100% sure, but if so, i'd rather not
touch this code, as we'd spend days reverting, fixing, and relanding this,
because our test coverage is super sparse :(

Implementing the other change without this one would mean to really apply the
patch locally, and check whether the result is the same as the current content
of the branch. That would make 'cl status' a non-readonly operation, which is
bad. At least, I don't know a way to just "virtually apply" a patch.

[tandrii(chromium), 2016-04-15 15:44:07]

On 2016/04/15 15:28:55, Clemens Hammacher wrote:
> On 2016/04/15 at 15:19:24, tandrii wrote:
> > see my comment on the CL that depends on this one. Maybe that other CL can
be
> written without these changes? I'm not 100% sure, but if so, i'd rather not
> touch this code, as we'd spend days reverting, fixing, and relanding this,
> because our test coverage is super sparse :(
> 
> Implementing the other change without this one would mean to really apply the
> patch locally, and check whether the result is the same as the current content
> of the branch. That would make 'cl status' a non-readonly operation, which is
> bad. 
Basically, I agree. But if you create a temporary branch and apply the patch on
it, while technically not read-only, it certainly doesn't interfere with a
developer's own branches.

> At least, I don't know a way to just "virtually apply" a patch.
Well, so for Rietveld, there is no way, other than above. For Gerrit, you one
can just fetch the ref with patch (see
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dde64625202248...)
and run git diff.

[Clemens Hammacher, 2016-04-22 09:57:51]

Description was changed from

==========
Support getting changes of non-HEAD branches

This requires passing the ref name to several places.

BUG=
==========

to

==========
Support getting changes of non-HEAD branches

This requires passing the ref name to several places.
==========

[Clemens Hammacher, 2016-05-06 12:26:10]

Description was changed from

==========
Support getting changes of non-HEAD branches

This requires passing the ref name to several places.
==========

to

==========
Support getting changes of non-HEAD branches

This requires passing the ref name to several places.
==========