Source/core/css/CSSCalculationValue.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSCalculationValue.h

diff --git a/Source/core/css/CSSCalculationValue.h b/Source/core/css/CSSCalculationValue.h

index ca4c5bfd24818561f43f06a899103a523a8bfd8d..d34a20bb5a5d205e1c1962d50200eb0880d2c9a3 100644

--- a/Source/core/css/CSSCalculationValue.h

+++ b/Source/core/css/CSSCalculationValue.h

@@ -57,13 +57,13 @@ enum CalculationCategory {

};

class CSSCalcExpressionNode : public RefCountedWillBeGarbageCollected<CSSCalcExpressionNode> {

+ DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_NONE(CSSCalcExpressionNode);

public:

enum Type {

CssCalcPrimitiveValue = 1,

CssCalcBinaryOperation

};

- virtual ~CSSCalcExpressionNode() = 0;

virtual bool isZero() const = 0;

virtual PassOwnPtr<CalcExpressionNode> toCalcValue(const CSSToLengthConversionData&) const = 0;

virtual double doubleValue() const = 0;