Source/core/css/CSSCalculationValue.cpp - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: removed dtor from HeapSupplement and derived classes Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSCalculationValue.cpp

diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp

index 8942913ca208ede61d59080ac534b37deddb54d2..d9a276e11f56d1a5cba13191ad882bda536c76f8 100644

--- a/Source/core/css/CSSCalculationValue.cpp

+++ b/Source/core/css/CSSCalculationValue.cpp

@@ -174,9 +174,7 @@ double CSSCalcValue::computeLengthPx(const CSSToLengthConversionData& conversion

return clampToPermittedRange(m_expression->computeLengthPx(conversionData));

}

-CSSCalcExpressionNode::~CSSCalcExpressionNode()

+DEFINE_EMPTY_DESTRUCTOR_WILL_BY_NONE(CSSCalcExpressionNode)

class CSSCalcPrimitiveValue FINAL : public CSSCalcExpressionNode {

WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;