Factor abstract base class IDLCompiler, concrete class IDLComplierV8

Factor abstract base class IDLCompiler, concrete class IDLComplierV8

This factors out the code common to all IDL compilers to IDLCompiler,
an abstract base class, and puts the V8-specific code in a concrete class.
This makes reuse easier, and has been requested by Terry (Dart) and Yosi
(Closure), and in any case makes the code very generic.

Also regularizes write_file(), so it's always on full file contents
(previously had 2 versions, one for full file contents (suitable for Jinja),
one for line-by-line (legacy from Perl)).

...and renames compile() to compile_file(), due to existing
built-in function compile() (causes misleading highlighting).

BUG=341748
R=haraken

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168824

[Nils Barth (inactive), 2014-03-10 05:50:43]

Here's the "base IDLCompiler class" CL that's been requested!

[kouhei (in TOK), 2014-03-10 06:01:51]

lgtm

https://codereview.chromium.org/189543008/diff/1/Source/bindings/scripts/idl_...
File Source/bindings/scripts/idl_compiler.py (right):

https://codereview.chromium.org/189543008/diff/1/Source/bindings/scripts/idl_...
Source/bindings/scripts/idl_compiler.py:95: self.code_generator = None  # Set in
derived class
optional nit: make this an arg of __init__ to enforce the rule?

[haraken, 2014-03-10 06:26:51]

LGTM

[Nils Barth (inactive), 2014-03-10 06:31:02]

https://codereview.chromium.org/189543008/diff/1/Source/bindings/scripts/idl_...
File Source/bindings/scripts/idl_compiler.py (right):

https://codereview.chromium.org/189543008/diff/1/Source/bindings/scripts/idl_...
Source/bindings/scripts/idl_compiler.py:95: self.code_generator = None  # Set in
derived class
On 2014/03/10 06:01:52, kouhei wrote:
> optional nit: make this an arg of __init__ to enforce the rule?

Done.
Thanks, that's a bit clearer!
In this case we constructor the CG after constructing the compiler
(to simplify parsing interfaces_info), but in general these can
be independent.

[Nils Barth (inactive), 2014-03-10 06:31:06]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-10 06:31:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/189543008/20001

[Nils Barth (inactive), 2014-03-10 06:32:47]

The CQ bit was unchecked by nbarth@chromium.org

[Nils Barth (inactive), 2014-03-10 06:35:54]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-10 06:36:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/189543008/40001

[commit-bot: I haz the power, 2014-03-10 07:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 07:04:53]

Try jobs failed on following builders: linux_blink_rel

[Nils Barth (inactive), 2014-03-10 07:11:46]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-10 07:12:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/189543008/40001

[commit-bot: I haz the power, 2014-03-10 07:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 07:27:36]

Try jobs failed on following builders: linux_blink_rel

[Nils Barth (inactive), 2014-03-10 08:40:43]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-03-10 08:41:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/189543008/40001

[commit-bot: I haz the power, 2014-03-10 09:24:02]

Change committed as 168824