Source/bindings/scripts/generate_global_constructors.py - Issue 189543008: Factor abstract base class IDLCompiler, concrete class IDLComplierV8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/generate_global_constructors.py

Issue 189543008: Factor abstract base class IDLCompiler, concrete class IDLComplierV8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: get_file_contents() Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/generate_global_constructors.py

diff --git a/Source/bindings/scripts/generate_global_constructors.py b/Source/bindings/scripts/generate_global_constructors.py

index 039ca0d2ddbfe2da2eae75a7ed9e4c7e9d895072..c98aeb4e301452d5230d47c63196a0577aca4f11 100755

--- a/Source/bindings/scripts/generate_global_constructors.py

+++ b/Source/bindings/scripts/generate_global_constructors.py

@@ -103,7 +103,7 @@ def write_global_constructors_partial_interface(interface_name, destination_file

# FIXME: sort by interface name (not first by extended attributes)

for constructor_attribute in sorted(constructor_attributes_list)] +

['};\n'])

- write_file(lines, destination_filename, only_if_changed)

+ write_file(''.join(lines), destination_filename, only_if_changed)

################################################################################