Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1895383002: Revert of Add SkEncodedInfo to report properties of encoded image data (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
msarett, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkEncodedInfo to report properties of encoded image data (patchset #6 id:200001 of https://codereview.chromium.org/1820073002/ ) Reason for revert: Lots of bots failing Original issue's description: > Add SkEncodedInfo to report properties of encoded image data > > All this does is build an SkEncodedInfo for each codec, and > then convert it to an SkImageInfo. > > In future steps I intend to: > (1) Use SkEncodedInfo in place of SrcConfig in SkSwizzler. > (2) Support more conversions in SkSwizzler (non-native > BGRA/RGBA, 16-bit components, float, fixed point) > (3) Investigate optimizing conversions from encoded data > to linear color spaces. > > BUG=skia:4133 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820073002 > > Committed: https://skia.googlesource.com/skia/+/f682d9ad70d690a343bc15e26ef321d86770be41 TBR=scroggo@google.com,reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4133 Committed: https://skia.googlesource.com/skia/+/3c920243f831de5892857f86618fd9c4f9655ba2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -439 lines) Patch
M include/codec/SkCodec.h View 4 chunks +1 line, -7 lines 0 comments Download
D include/codec/SkEncodedInfo.h View 1 chunk +0 lines, -178 lines 0 comments Download
M src/codec/SkBmpCodec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkBmpCodec.cpp View 5 chunks +30 lines, -52 lines 0 comments Download
M src/codec/SkBmpMaskCodec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkBmpMaskCodec.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkBmpRLECodec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codec/SkBmpRLECodec.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkBmpStandardCodec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codec/SkBmpStandardCodec.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/codec/SkCodec.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/codec/SkGifCodec.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/codec/SkGifCodec.cpp View 2 chunks +16 lines, -14 lines 0 comments Download
M src/codec/SkIcoCodec.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/codec/SkIcoCodec.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/codec/SkJpegCodec.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M src/codec/SkJpegDecoderMgr.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/codec/SkJpegDecoderMgr.cpp View 1 chunk +3 lines, -11 lines 0 comments Download
M src/codec/SkPngCodec.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 11 chunks +55 lines, -57 lines 0 comments Download
M src/codec/SkRawCodec.cpp View 4 chunks +6 lines, -19 lines 0 comments Download
M src/codec/SkWbmpCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkWbmpCodec.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/codec/SkWebpCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkWebpCodec.cpp View 3 chunks +13 lines, -46 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Add SkEncodedInfo to report properties of encoded image data
4 years, 8 months ago (2016-04-19 11:40:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895383002/1
4 years, 8 months ago (2016-04-19 11:40:56 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 11:41:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3c920243f831de5892857f86618fd9c4f9655ba2

Powered by Google App Engine
This is Rietveld 408576698