Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189503004: Reserve more IDs for AC dynamic field trials. (Closed)

Created:
6 years, 9 months ago by Bart N.
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Reserve more IDs for AC dynamic field trials. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/common/metrics/variations/variation_ids.h View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Bart N.
Hi, it's ready for review.
6 years, 9 months ago (2014-03-07 02:30:03 UTC) #1
H Fung
lgtm
6 years, 9 months ago (2014-03-07 02:31:31 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 9 months ago (2014-03-07 16:17:09 UTC) #3
Bart N.
The CQ bit was checked by bartn@chromium.org
6 years, 9 months ago (2014-03-07 16:50:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartn@chromium.org/189503004/1
6 years, 9 months ago (2014-03-07 16:52:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 16:56:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 16:56:22 UTC) #7
Bart N.
The CQ bit was checked by bartn@chromium.org
6 years, 9 months ago (2014-03-07 20:39:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartn@chromium.org/189503004/1
6 years, 9 months ago (2014-03-07 20:40:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartn@chromium.org/189503004/1
6 years, 9 months ago (2014-03-08 10:56:34 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:58:47 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234347
6 years, 9 months ago (2014-03-08 13:58:48 UTC) #12
Bart N.
The CQ bit was checked by bartn@chromium.org
6 years, 9 months ago (2014-03-08 14:39:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartn@chromium.org/189503004/1
6 years, 9 months ago (2014-03-08 14:39:53 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 15:16:36 UTC) #15
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234412
6 years, 9 months ago (2014-03-08 15:16:36 UTC) #16
Bart N.
The CQ bit was checked by bartn@chromium.org
6 years, 9 months ago (2014-03-09 01:44:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartn@chromium.org/189503004/1
6 years, 9 months ago (2014-03-09 01:44:56 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 02:39:03 UTC) #19
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234685
6 years, 9 months ago (2014-03-09 02:39:03 UTC) #20
Bart N.
The CQ bit was checked by bartn@chromium.org
6 years, 9 months ago (2014-03-09 04:26:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartn@chromium.org/189503004/1
6 years, 9 months ago (2014-03-09 04:27:07 UTC) #22
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 04:40:27 UTC) #23
Message was sent while issue was closed. 
Change committed as 255823

Powered by Google App Engine
This is Rietveld 408576698