Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7797)

Unified Diff: chrome/common/metrics/variations/variation_ids.h

Issue 189503004: Reserve more IDs for AC dynamic field trials. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics/variations/variation_ids.h
diff --git a/chrome/common/metrics/variations/variation_ids.h b/chrome/common/metrics/variations/variation_ids.h
index 0b6cf241bb51a1b19cb32142919d7a250a53a2eb..1d9ed01964739906eba95aa186bd3f58f707b5ea 100644
--- a/chrome/common/metrics/variations/variation_ids.h
+++ b/chrome/common/metrics/variations/variation_ids.h
@@ -182,7 +182,7 @@ enum ReservedVariationID {
// For more details, see
// chrome/browser/omnibox/omnibox_field_trial.{h,cc}.
AUTOCOMPLETE_DYNAMIC_FIELD_TRIAL_ID_MIN = 3310086,
- AUTOCOMPLETE_DYANMIC_FIELD_TRIAL_ID_MAX = 3310185,
+ AUTOCOMPLETE_DYNAMIC_FIELD_TRIAL_ID_MAX = 3310185,
// BookmarkPrompt field trial.
BOOKMARK_PROMPT_TRIAL_DEFAULT = 3310186,
@@ -265,7 +265,7 @@ enum ReservedVariationID {
// For more details, see
// chrome/browser/omnibox/omnibox_field_trial.{h,cc}.
AUTOCOMPLETE_DYNAMIC_FIELD_TRIAL_RANGE2_ID_MIN = 3311947,
- AUTOCOMPLETE_DYANMIC_FIELD_TRIAL_RANGE2_ID_MAX = 3312046,
+ AUTOCOMPLETE_DYNAMIC_FIELD_TRIAL_RANGE2_ID_MAX = 3312046,
// DEPRECATED - DO NOT USE
// Name: IOSPhoneNewNTP
@@ -310,10 +310,18 @@ enum ReservedVariationID {
LINK_REL_PREFETCH_DISABLED_1 = 3312120,
LINK_REL_PREFETCH_DISABLED_2 = 3312121,
+ // Reserve 200 more IDs to be used by autocomplete dynamic field trials.
+ // The dynamic field trials are activated by a call to
+ // OmniboxFieldTrial::ActivateDynamicFieldTrials.
+ // For more details, see
+ // chrome/browser/omnibox/omnibox_field_trial.{h,cc}.
+ AUTOCOMPLETE_DYNAMIC_FIELD_TRIAL_RANGE3_ID_MIN = 3312122,
+ AUTOCOMPLETE_DYNAMIC_FIELD_TRIAL_RANGE3_ID_MAX = 3312321,
+
// NEXT ID: When adding new IDs, please add them above this section, starting
// with the value of NEXT_ID, and updating NEXT_ID to (end of your reserved
// range) + 1.
- NEXT_ID = 3312122,
+ NEXT_ID = 3312322,
// USABLE IDs END HERE.
//
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698