Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Issue 1894973005: Don't clear metrics_client_id on shutdown (Closed)

Created:
4 years, 8 months ago by scottmg
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't clear metrics_client_id on shutdown Because we use the same path for disabling as shutdown, the metrics_client_id crash key gets cleared during browser shutdown. This is undesireable because then it won't be there for crashes that happen late in shutdown. Avoid this by simply not clearing it when shutting down. R=asvitkine@chromium.org BUG=604487 Committed: https://crrev.com/e5170aea4b461dd96aade4f9b7ba2fe8d67fe096 Cr-Commit-Position: refs/heads/master@{#388215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
4 years, 8 months ago (2016-04-18 22:39:41 UTC) #1
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-19 13:45:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894973005/1
4 years, 8 months ago (2016-04-19 15:39:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 15:42:55 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:12:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5170aea4b461dd96aade4f9b7ba2fe8d67fe096
Cr-Commit-Position: refs/heads/master@{#388215}

Powered by Google App Engine
This is Rietveld 408576698